Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary deallocate #345

Merged
merged 1 commit into from
Mar 22, 2023

Conversation

billsacks
Copy link
Member

Description of changes

fieldNameList is not always allocated, so this deallocate caused problems in some circumstances. We could wrap the deallocate in a conditional, but since allocatable arrays are automatically deallocated upon leaving a subroutine, this deallocate statement is unnecessary.

Specific notes

Contributors other than yourself, if any: @olyson found this issue

CMEPS Issues Fixed (include github issue #): none

Are changes expected to change answers? (specify if bfb, different at roundoff, more substantial) NO

Any User Interface Changes (namelist or namelist defaults changes)? none

Testing performed

NONE

Testing performed if application target is CESM:

  • (recommended) CIME_DRIVER=nuopc scripts_regression_tests.py
    • machines:
    • details (e.g. failed tests):
  • (recommended) CESM testlist_drv.xml
    • machines and compilers:
    • details (e.g. failed tests):
  • (optional) CESM prealpha test
    • machines and compilers
    • details (e.g. failed tests):
  • (other) please described in detail
    • machines and compilers
    • details (e.g. failed tests):

Testing performed if application target is UFS-coupled:

  • (recommended) UFS-coupled testing
    • description:
    • details (e.g. failed tests):

Testing performed if application target is UFS-HAFS:

  • (recommended) UFS-HAFS testing
    • description:
    • details (e.g. failed tests):

Hashes used for testing:

  • CESM:
  • UFS-coupled, then umbrella repostiory to check out and associated hash:
    • repository to check out:
    • branch/hash:
  • UFS-HAFS, then umbrella repostiory to check out and associated hash:
    • repository to check out:
    • branch/hash:

fieldNameList is not always allocated. We could wrap the deallocate in a
conditional, but since allocatable arrays are automatically deallocated
upon leaving a subroutine, this deallocate statement is unnecessary.
@jedwards4b jedwards4b merged commit 97a4fe1 into ESCOMP:main Mar 22, 2023
@billsacks billsacks deleted the remove_unnecessary_deallocate branch March 22, 2023 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants