Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mapping and Pole method changes for WW3DEV->MOM6 coupling #240

Merged
merged 2 commits into from
Oct 18, 2021

Conversation

alperaltuntas
Copy link
Member

Description of changes

  • Adds the new ww3->ocn export fields for SURFBANDS wave coupling method, i.e., the partitioned stokes drift components in x and y directions.
  • Changes wav online mapping to bilnr_nstod. This only affects the new ww3dev code since the legacy ww3 code doesn't use online mapping.
  • Sets the polemethod to NONE for all of the wave import/export fields and updates the mask for wav->ocn mapping. This is needed because the wave grid has triangles along the tripolar stitch, which triggers an ESMF error when POLEMETHOD_ALLAVG is used. This change also only affects the new ww3dev code since the legacy ww3 code doesn't use online mapping.

Specific notes

Contributors other than yourself, if any:

CMEPS Issues Fixed (include github issue #):

Are changes expected to change answers?

  • bit for bit
  • different at roundoff level
  • more substantial

Any User Interface Changes (namelist or namelist defaults changes)?

  • Yes
  • No

Testing performed if application target is CESM:(either UFS-S2S or CESM testing is required):
All passing: (including baseline test)
SMS_Vnuopc.f09_g17.B1850.cheyenne_intel
SMS_Vnuopc.T62_g17.G1850ECO.cheyenne_intel
ERS_Vnuopc.TL319_g17.GIAF_JRA.cheyenne_gnu
ERS_Vnuopc.TL319_t061.GMOM_JRA_WD.cheyenne_gnu
SMS_Vnuopc.TL319_t061.GMOM_JRA.cheyenne_intel
ERS_Vnuopc.TL319_t061_wt061.GMOM_JRA_WD.cheyenne_gnu

Hashes used for testing:
cesm2_3_beta06

Copy link
Collaborator

@DeniseWorthen DeniseWorthen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@mvertens mvertens merged commit abc117d into ESCOMP:master Oct 18, 2021
@mvertens
Copy link
Collaborator

@uturuncoglu @denise - thanks so much for your quick response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants