-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding support to run CDEPS as a part of HAFS application #115
Conversation
@mvertens i am testing it with CESM application now. @DeniseWorthen if you could test it with S2S that would be great because I update PIO and build system to support HAFS application. |
For the ufs applications, we've actually taken internal PIO lib build out of cmeps (remove from nems/lib). Instead use what is in the hpc stack. This was part of the move to cmake. |
@DeniseWorthen yes, I know but all the UFS models are not synchronized and they are not using the same code base. So, this will allow us to support both PIO configuration in the same time at least for the near future. |
@mvertens @DeniseWorthen could you review this and let me know if there is an issue. I need to merge it with master to continue to work on HAFS CDEPS integration. |
We've removed ParallelIIO as a submodule, so I can merge this and test we can still build and run but it won't be testing the new PIO if that is your concern. |
@DeniseWorthen Thanks for your reminder. That is great but i still need this PR to work with HAFS. Once HAFS app also follow the same way with S2S, all PIO related stuff can be removed from the CMEPS. |
@mvertens @DeniseWorthen It turns out that this PR gets old and it has problem. I am creating a new branch top of master (feature/hafs_cdeps_fixed) and I am currently testing it and once it passes under HAFS app, I'll close this PR and open a new one, if you don't mind. |
* add cpl_scalar for tiled grids, other minor fixes * add new cpl_scalar for mediator history files for tiled gridded domains * remove unnecessary trims, fix minor typos and indentation * set ntile=0 when ntile scalar doesn't exist * modify dstmask for lnd->atm in UFS Co-authored-by: uturuncoglu <[email protected]>
Description of changes
This PR aims to support CDEPS as a part of HAFS application and including following modifications:
Specific notes
Testing with S2S is critical since we change the PIO version and Makefiles under news directory. @DeniseWorthen if you could test it with S2S that would be great.
Contributors other than yourself, if any:
CMEPS Issues Fixed (include github issue #):
Are changes expected to change answers?
Any User Interface Changes (namelist or namelist defaults changes)?
Testing performed if application target is CESM:(either UFS-S2S or CESM testing is required):
Testing performed if application target is UFS-S2S:
Hashes used for testing: