Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding support to run CDEPS as a part of HAFS application #115

Closed
wants to merge 7 commits into from

Conversation

uturuncoglu
Copy link
Collaborator

@uturuncoglu uturuncoglu commented Oct 20, 2020

Description of changes

This PR aims to support CDEPS as a part of HAFS application and including following modifications:

  • PIO and genf90 are updated to latest versions. This is required to support CDEPS that requires newer version of PIO. Currently, CDEPS uses PIO installed along with CMEPS under HAFS application
  • It makes PIO initialization optional. HAFS application initializes PIO in the NEMS driver because HAFS application has both CMEPS and CDEPS and both of them requires PIO

Specific notes

Testing with S2S is critical since we change the PIO version and Makefiles under news directory. @DeniseWorthen if you could test it with S2S that would be great.

Contributors other than yourself, if any:

CMEPS Issues Fixed (include github issue #):

Are changes expected to change answers?

  • bit for bit
  • different at roundoff level
  • more substantial

Any User Interface Changes (namelist or namelist defaults changes)?

  • Yes
  • No

Testing performed if application target is CESM:(either UFS-S2S or CESM testing is required):

  • (required) CIME_DRIVER=nuopc scripts_regression_tests.py
    • machines:
    • details (e.g. failed tests):
  • (required) CESM testlist_drv.xml
    • machines and compilers: Cheyenne, Intel + MPT
    • details (e.g. failed tests):
qcmd -l walltime=4:00:00 -- ./create_test --xml-testlist ../src/drivers/nuopc/cime_config/testdefs/testlist_drv.xml --xml-machine cheyenne --xml-category nuopc --compare oct14 --baseline-root /glade/p/cesmdata/cseg/cmeps_baselines
    FAIL ERS_Vnuopc_Ld5.f19_f19_mg17.I2000Clm50Sp.cheyenne_intel.clm-default TPUTCOMP Error: Computation time increase > 25 pct from baseline
    FAIL ERS_Vnuopc_Ln9_N3.f19_g17_rx1.A.cheyenne_intel TPUTCOMP Error: Computation time increase > 25 pct from baseline
    FAIL SMS_Vnuopc_Ld1_N3.f19_g17_rx1.A.cheyenne_intel TPUTCOMP Error: Computation time increase > 25 pct from baseline
    FAIL SMS_Vnuopc_Ld5.f19_g16.BMOM.cheyenne_intel.allactive-nuopc_cap_io MEMCOMP Error: Memory usage increase > 10% from baseline
  • (optional) CESM prealpha test
    • machines and compilers
    • details (e.g. failed tests):

Testing performed if application target is UFS-S2S:

  • (required) UFS-S2S testing
    • description:
    • details (e.g. failed tests):

Hashes used for testing:

@uturuncoglu uturuncoglu marked this pull request as draft October 20, 2020 22:35
@uturuncoglu
Copy link
Collaborator Author

@mvertens i am testing it with CESM application now. @DeniseWorthen if you could test it with S2S that would be great because I update PIO and build system to support HAFS application.

@DeniseWorthen
Copy link
Collaborator

For the ufs applications, we've actually taken internal PIO lib build out of cmeps (remove from nems/lib). Instead use what is in the hpc stack. This was part of the move to cmake.

@uturuncoglu
Copy link
Collaborator Author

uturuncoglu commented Oct 21, 2020

@DeniseWorthen yes, I know but all the UFS models are not synchronized and they are not using the same code base. So, this will allow us to support both PIO configuration in the same time at least for the near future.

@DeniseWorthen
Copy link
Collaborator

DeniseWorthen commented Oct 23, 2020

I believe these two lines mediator/Makefile

med_utils_mod.o : med_kind_mod.o med_utils_mod.F90

med_diag_mod.o : med_kind_mod.o med_time_mod.o med_utils_mod.o med_methods_mod.o med_internalstate_mod.o med_diag_mod.F90

need the .F90s removed.

@uturuncoglu uturuncoglu marked this pull request as ready for review October 28, 2020 20:23
@uturuncoglu uturuncoglu changed the title DRAFT: adding support to run CDEPS as a part of HAFS application adding support to run CDEPS as a part of HAFS application Oct 28, 2020
@uturuncoglu
Copy link
Collaborator Author

@mvertens @DeniseWorthen could you review this and let me know if there is an issue. I need to merge it with master to continue to work on HAFS CDEPS integration.

@uturuncoglu uturuncoglu self-assigned this Oct 28, 2020
@DeniseWorthen
Copy link
Collaborator

DeniseWorthen commented Oct 28, 2020

We've removed ParallelIIO as a submodule, so I can merge this and test we can still build and run but it won't be testing the new PIO if that is your concern.

@uturuncoglu
Copy link
Collaborator Author

@DeniseWorthen Thanks for your reminder. That is great but i still need this PR to work with HAFS. Once HAFS app also follow the same way with S2S, all PIO related stuff can be removed from the CMEPS.

@uturuncoglu
Copy link
Collaborator Author

@mvertens @DeniseWorthen It turns out that this PR gets old and it has problem. I am creating a new branch top of master (feature/hafs_cdeps_fixed) and I am currently testing it and once it passes under HAFS app, I'll close this PR and open a new one, if you don't mind.

@uturuncoglu uturuncoglu deleted the feature/hafs_cdeps branch October 30, 2020 19:47
jedwards4b pushed a commit that referenced this pull request Jun 24, 2024
* add cpl_scalar for tiled grids, other minor fixes
* add new cpl_scalar for mediator history files for tiled gridded domains
* remove unnecessary trims, fix minor typos and indentation
* set ntile=0 when ntile scalar doesn't exist
* modify dstmask for lnd->atm in UFS


Co-authored-by: uturuncoglu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants