Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to handle mesh files that don't have center coordinates #71

Closed
ekluzek opened this issue Jun 23, 2020 · 1 comment
Closed
Labels
enhancement New feature or request wontfix This will not be worked on

Comments

@ekluzek
Copy link
Collaborator

ekluzek commented Jun 23, 2020

For meshes with mizuRoute we don't plan to have center coordinates. The meshes are complex with hundreds to thousands of vertices for each cell, so center coordinates aren't useful. We do have HRU Id's (Hydrologic Response Unit identifiers), that are either strings or integers to have an unique identifier for each cell. The HRU Id's are helpful inside of mizuRoute, but may not be useful for the mediator. But, if the history writing needs a unique identifier it might be useful to use it rather than center coordinates.

Technically center coordinates could be calculated for each cell, but they don't tend to be useful at identifying grid cells readily (where HRU Id's are useful), and technically you could have concave cells that nest into each other and have close if not exactly the same nested coordinates (in practice this is unlikely).

Without center coordinates our cases trigger an error at the following point in med_io_mod.F90.

    if (.not. allocated(ownedElemCoords) .and. ndims > 0 .and. nelements > 0) then
       allocate(ownedElemCoords(ndims*nelements))
       allocate(ownedElemCoords_x(ndims*nelements/2))
       allocate(ownedElemCoords_y(ndims*nelements/2))

       call ESMF_MeshGet(mesh, ownedElemCoords=ownedElemCoords, rc=rc)
       if (chkerr(rc,__LINE__,u_FILE_u)) return.   _**<<<<<<<<<<<< Returns here**_

       ownedElemCoords_x = ownedElemCoords(1::2)
       ownedElemCoords_y = ownedElemCoords(2::2)
    end if

There likely are other changes in the code to compensate for the lack of center coordinates. So we need a plan on how to handle this.

@mvertens mvertens added the enhancement New feature or request label Jul 2, 2020
@ekluzek ekluzek added the wontfix This will not be worked on label Dec 9, 2020
@ekluzek
Copy link
Collaborator Author

ekluzek commented Dec 9, 2020

This might be something we still want. But, for now we are just using mesh files with center coordinates. So we don't need this right now. So I'm marking this as a wontfix. If we decide we need it later we can add it back in or create another issue for it.

@ekluzek ekluzek closed this as completed Dec 9, 2020
jedwards4b added a commit to jedwards4b/CMEPS that referenced this issue Jun 9, 2022
this compset should not produce an ocn stream file
### Description of changes
add docn_mode som_aquap to those that do not produce a stream file.

### Specific notes

Contributors other than yourself, if any:

CDEPS Issues Fixed (include github issue #): ESCOMP#70

Are there dependencies on other component PRs
 - [ ] CIME (list)
 - [ ] CMEPS (list) 

Are changes expected to change answers?
 - [ ] bit for bit
 - [ ] different at roundoff level
 - [ ] more substantial 

Any User Interface Changes (namelist or namelist defaults changes)?
 - [ ] Yes
 - [X] No

Testing performed:
- [ ] (required) aux_cdeps
   - machines and compilers:
   - details (e.g. failed tests):
- [ ] (optional) CESM prealpha test
   - machines and compilers
   - details (e.g. failed tests):

Hashes used for testing:
- [X] CIME
  - repository to check out: https://github.com/ESCOMP/CESM.git
  - branch: master
  - hash: 8b48a2e2d4b
- [X] CMEPS
  - repository to check out: https://github.com/ESCOMP/CESM.git
  - branch: nuopc_dev
  - hash: c0c2001
- [ ] CESM
  - repository to check out: https://github.com/ESCOMP/CESM.git
  - branch: nuopc_dev
  - hash:
jedwards4b added a commit to jedwards4b/CMEPS that referenced this issue Jun 9, 2022
### Description of changes
Add back stream files for docn_mode=='som_aquap'  PR ESCOMP#71 broke several compsets.  

### Specific notes

Contributors other than yourself, if any:

CMEPS Issues Fixed (include github issue #):

Are there dependencies on other component PRs
 - [ ] CIME (list)
 - [ ] CMEPS (list) 

Are changes expected to change answers?
 - [X] bit for bit
 - [ ] different at roundoff level
 - [ ] more substantial 

Any User Interface Changes (namelist or namelist defaults changes)?
 - [ ] Yes
 - [X] No

Testing performed:
- [X] (required) aux_cdeps
   - machines and compilers: cheyenne, intel 
   - details (e.g. failed tests): ALL pass also tested with PR#73 merged.
   
- [ ] (optional) CESM prealpha test
   - machines and compilers
   - details (e.g. failed tests):

Hashes used for testing:
- [X] CIME
  - repository to check out: https://github.com/ESCOMP/CESM.git
  - branch: master
  - hash: 296aeaf4a
- [X] CMEPS
  - repository to check out: https://github.com/ESCOMP/CESM.git
  - branch: master 
  - hash:c0c2001
- [ ] CESM
  - repository to check out: https://github.com/ESCOMP/CESM.git
  - branch: 
  - hash:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants