Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiling error when ESMF_AWARE_THREADING is on #482

Closed
nmizukami opened this issue Jul 10, 2024 · 1 comment · Fixed by #485
Closed

Compiling error when ESMF_AWARE_THREADING is on #482

nmizukami opened this issue Jul 10, 2024 · 1 comment · Fixed by #485
Assignees
Labels
bug Something isn't working CESM only

Comments

@nmizukami
Copy link

I am trying to run hybrid parallel configuration in CTSM-mizuRoute. pelayout is set to like this (see ROF)

Comp  NTASKS  NTHRDS  ROOTPE PSTRIDE
CPL :   3840/     1;    128      1
ATM :    128/     1;      0      1
LND :   3840/     1;    128      1
ICE :   3840/     1;    128      1
OCN :   3840/     1;    128      1
ROF :    128/    10;    128      1
GLC :   3840/     1;    128      1
WAV :   3840/     1;    128      1
ESP :      1/     1;      0      1
ESMF_AWARE_THREADING is True

Now, I get compiling error, coming from undefined variables

/glade/u/home/mizukami/proj/ctsm-mizuRoute/CTSM/components/cmeps/cime_config/../cesm/driver/esm.F90(1004): error #6404: This name does not have a type, and must have an explicit type.   [CNT]
/glade/u/home/mizukami/proj/ctsm-mizuRoute/CTSM/components/cmeps/cime_config/../cesm/driver/esm.F90(1099): error #6498: The use-name for this local-name is not defined.   [ROFSETVM]

First one is easily fixed by just adding line integer:: cnt in esm.F90 file
Fixing the second error require adding few lines in /nuopc/rof_comp_nuopc.F90 in ROF model (here mizuRoute), adding use NUOPC_Model , only : SetVM and public :: SetVM. This is how MOSART code does now.

I am using cmeps_v0.4.1-2792-g16abe9e7, which is old. However, cmeps1.0.2 has the same issue.

@ekluzek ekluzek added bug Something isn't working CESM only labels Jul 10, 2024
@billsacks billsacks self-assigned this Jul 12, 2024
billsacks added a commit to billsacks/CMEPS that referenced this issue Jul 12, 2024
This was mistakenly removed in 4d9073d when cleaning up unused
variables.

Resolves ESCOMP#482
@billsacks
Copy link
Member

Thanks for reporting and diagnosing the issue. I have opened a PR to fix this (#485) - note that the declaration needs to be in an ifdef to avoid compiler warnings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CESM only
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants