Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mizuRoute as an external #157

Merged
merged 4 commits into from
Jul 4, 2020
Merged

Conversation

ekluzek
Copy link
Contributor

@ekluzek ekluzek commented Jun 3, 2020

Description of changes

Add mizuRoute as an external. This will also need an update to CTSM. This is just for the nuopc_dev branch right now.

Specific notes

There are also branch changes in CTSM that are needed for it to work.

Contributors other than yourself, if any: Naoki Mizukami

User interface changes?: No

Testing performed (automated tests and/or manual tests):
SMS_D_P5x1_Vnuopc_Ld5.5x5_amazon_r05.I2000Clm50SpMizGs.cheyenne_intel.mizuroute-default
SMS_D_P36x1_Vnuopc_Ld10.f19_g17_r05.I2000Clm50SpMizGs.cheyenne_intel.mizuroute-default

@jedwards4b jedwards4b marked this pull request as draft June 3, 2020 19:28
@jedwards4b
Copy link
Contributor

I have converted the PR to draft for discussion.

@ekluzek ekluzek changed the title Add mizuRoute as an external (DONT merge yet) Add mizuRoute as an external Jul 1, 2020
@ekluzek
Copy link
Contributor Author

ekluzek commented Jul 1, 2020

OK, I get tests to pass up to the SHORT_TERM_ARCHIVER (there's an issue in mizuRoute that doesn't let it complete -- mizuRoute history files don't include the casename right now).

The two tests I ran are:

SMS_D_P36x1_Vnuopc_Ld10.f19_g17_r05.I2000Clm50SpMizGs.cheyenne_intel.mizuroute-default
SMS_D_P5x1_Vnuopc_Ld5.5x5_amazon_r05.I2000Clm50SpMizGs.cheyenne_intel.mizuroute-default

TestStatus looks like this:

PASS SMS_D_P5x1_Vnuopc_Ld5.5x5_amazon_r05.I2000Clm50SpMizGs.cheyenne_intel.mizuroute-default CREATE_NEWCASE
PASS SMS_D_P5x1_Vnuopc_Ld5.5x5_amazon_r05.I2000Clm50SpMizGs.cheyenne_intel.mizuroute-default XML
PASS SMS_D_P5x1_Vnuopc_Ld5.5x5_amazon_r05.I2000Clm50SpMizGs.cheyenne_intel.mizuroute-default SETUP
PASS SMS_D_P5x1_Vnuopc_Ld5.5x5_amazon_r05.I2000Clm50SpMizGs.cheyenne_intel.mizuroute-default SHAREDLIB_BUILD time=236
PASS SMS_D_P5x1_Vnuopc_Ld5.5x5_amazon_r05.I2000Clm50SpMizGs.cheyenne_intel.mizuroute-default MODEL_BUILD time=44
PASS SMS_D_P5x1_Vnuopc_Ld5.5x5_amazon_r05.I2000Clm50SpMizGs.cheyenne_intel.mizuroute-default SUBMIT
PASS SMS_D_P5x1_Vnuopc_Ld5.5x5_amazon_r05.I2000Clm50SpMizGs.cheyenne_intel.mizuroute-default RUN time=68
PASS SMS_D_P5x1_Vnuopc_Ld5.5x5_amazon_r05.I2000Clm50SpMizGs.cheyenne_intel.mizuroute-default MEMLEAK
FAIL SMS_D_P5x1_Vnuopc_Ld5.5x5_amazon_r05.I2000Clm50SpMizGs.cheyenne_intel.mizuroute-default SHORT_TERM_ARCHIVER exception

@ekluzek ekluzek marked this pull request as ready for review July 1, 2020 23:12
@ekluzek ekluzek requested a review from mvertens July 1, 2020 23:15
Copy link
Contributor

@mvertens mvertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please replace branches with hashes.
Also - can we possibly bring your changes to mosart master? Not for this PR but as soon as possible.

@mvertens mvertens merged commit c025680 into ESCOMP:nuopc_dev Jul 4, 2020
@ekluzek
Copy link
Contributor Author

ekluzek commented Jul 6, 2020

@mvertens should I create a new PR that points to hashes rather than branches?

I will get the MOSART and RTM changes to master for them. Priority is for the CESM2.2 release and PPE branches though, so I'm not sure when I can get that done.

@mvertens
Copy link
Contributor

mvertens commented Jul 6, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants