-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mizuRoute as an external #157
Conversation
I have converted the PR to draft for discussion. |
OK, I get tests to pass up to the SHORT_TERM_ARCHIVER (there's an issue in mizuRoute that doesn't let it complete -- mizuRoute history files don't include the casename right now). The two tests I ran are: SMS_D_P36x1_Vnuopc_Ld10.f19_g17_r05.I2000Clm50SpMizGs.cheyenne_intel.mizuroute-default TestStatus looks like this: PASS SMS_D_P5x1_Vnuopc_Ld5.5x5_amazon_r05.I2000Clm50SpMizGs.cheyenne_intel.mizuroute-default CREATE_NEWCASE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please replace branches with hashes.
Also - can we possibly bring your changes to mosart master? Not for this PR but as soon as possible.
@mvertens should I create a new PR that points to hashes rather than branches? I will get the MOSART and RTM changes to master for them. Priority is for the CESM2.2 release and PPE branches though, so I'm not sure when I can get that done. |
Sorry - I accepted the PR without realizing that you had not made this
change.
Please reopen your PR and change them to hashes.
Since then I have updated the nuopc_dev to have a newer cmeps and cime -
but this was carefully tested in my PR.
…On Mon, Jul 6, 2020 at 1:49 PM Erik Kluzek ***@***.***> wrote:
@mvertens <https://github.com/mvertens> should I create a new PR that
points to hashes rather than branches?
I will get the MOSART and RTM changes to master for them. Priority is for
the CESM2.2 release and PPE branches though, so I'm not sure when I can get
that done.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#157 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB4XCE2IARBODBDOEHSXPNLR2ITC3ANCNFSM4NR6NE7A>
.
--
Mariana Vertenstein
CESM Software Engineering Group Head
National Center for Atmospheric Research
Boulder, Colorado
Office 303-497-1349
Email: [email protected]
|
Description of changes
Add mizuRoute as an external. This will also need an update to CTSM. This is just for the nuopc_dev branch right now.
Specific notes
There are also branch changes in CTSM that are needed for it to work.
Contributors other than yourself, if any: Naoki Mizukami
User interface changes?: No
Testing performed (automated tests and/or manual tests):
SMS_D_P5x1_Vnuopc_Ld5.5x5_amazon_r05.I2000Clm50SpMizGs.cheyenne_intel.mizuroute-default
SMS_D_P36x1_Vnuopc_Ld10.f19_g17_r05.I2000Clm50SpMizGs.cheyenne_intel.mizuroute-default