Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUN_TYPE and GET_REFCASE wrong for SSP extensions #148

Closed
ekluzek opened this issue Apr 6, 2020 · 4 comments
Closed

RUN_TYPE and GET_REFCASE wrong for SSP extensions #148

ekluzek opened this issue Apr 6, 2020 · 4 comments
Assignees
Labels
Milestone

Comments

@ekluzek
Copy link
Contributor

ekluzek commented Apr 6, 2020

Summary of Issue:

RUN_TYPE and GET_REFCASE are wrong fro the SSP extensions

Expected behavior and actual behavior:

RUN_TYPE is startup but should be hybrid
and GET_REF_CASE is FALSE, but should be TRUE

Steps to reproduce the problem. Include externals description file(s) and link to public repository):

Setup a case for: BWSSP585extcmip6, BWSSP534osextcmip6, or BWSSP126extcmip6

What is the changeset ID of the code, and the machine you are using:

cesm2.1.4-rc.01

on cheyenne, but machine doesn't matter.

have you modified the code? If so, it must be committed and available for testing: No

@ekluzek ekluzek added the bug label Apr 6, 2020
@ekluzek ekluzek added this to the CESM2.1.4 milestone Apr 6, 2020
@ekluzek ekluzek self-assigned this Apr 6, 2020
@ekluzek
Copy link
Contributor Author

ekluzek commented Apr 6, 2020

GET_REFCASE isn't being set to TRUE for most cases. It seems like it should be for cases when REFCASE is set. I'm adding changes that set GET_REFCASE to TRUE when these particular compsets are triggered, but it seems like it should be more general than that.

@jedwards4b and @fischer-ncar can you comment on this? Should GET_REFCASE be set more generally? Or just for these extension compsets? Or should I leave GET_REFCASE like it is?

@jedwards4b
Copy link
Contributor

GET_REFCASE should only be true for the specific compsets that have refcases in inputdata, do not set it in general or we will be getting lots of requests for data that isn't there.

@ekluzek
Copy link
Contributor Author

ekluzek commented Apr 6, 2020

Well my point is that there's a ton of specific settings for specific REFCASES that are NOT setting GET_REFCASE to TRUE and seem like they should. For here I'm just adding these specific REFCASES for GET_REFCASE, but it seems like these other REFCASES should set it as well. I don't mean a general setting for everything, but for the specific compsets that do set a REFCASE.

ekluzek added a commit to ekluzek/CESM that referenced this issue Apr 6, 2020
@ekluzek
Copy link
Contributor Author

ekluzek commented May 3, 2024

Looks like this was merged, so closing.

@ekluzek ekluzek closed this as completed May 3, 2024
RafaPedroFernandez pushed a commit to RafaPedroFernandez/CESM that referenced this issue May 31, 2024
cam6_2_030: Fix for floating point issue in GW drag.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants