Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Neon streams #50

Merged
merged 9 commits into from
Apr 23, 2021
Merged

Neon streams #50

merged 9 commits into from
Apr 23, 2021

Conversation

jedwards4b
Copy link
Contributor

@jedwards4b jedwards4b commented Feb 9, 2021

Description of changes

Adds support for NEON tower data in datm.

Specific notes

Contributors other than yourself, if any:

CMEPS Issues Fixed (include github issue #):

Are there dependencies on other component PRs

Are changes expected to change answers?

  • bit for bit
  • different at roundoff level
  • more substantial

Any User Interface Changes (namelist or namelist defaults changes)?

  • Yes
  • No

Testing performed:

  • (required) aux_cdeps
    • machines and compilers: cheyenne intel
    • details (e.g. failed tests): SMS_Vnuopc_Ld5.TL319_t061.2000_DATM%JRA-1p4-2018_SLND_SICE_SOCN_SROF_SGLC_SWAV_SESP.cheyenne_intel fails in build with
      Invalid values ['CORE_IAF_JRA_1p4_2018']
  • (optional) CESM prealpha test
    • machines and compilers
    • details (e.g. failed tests):

Hashes used for testing:

@jedwards4b jedwards4b marked this pull request as draft February 9, 2021 15:27
@jedwards4b jedwards4b requested a review from mvertens April 16, 2021 15:53
@jedwards4b jedwards4b self-assigned this Apr 16, 2021
@jedwards4b jedwards4b marked this pull request as ready for review April 16, 2021 15:56
@jedwards4b jedwards4b requested a review from uturuncoglu April 20, 2021 17:03
@@ -65,7 +68,7 @@
<type>char</type>
<category>datm</category>
<group>datm_nml</group>
<valid_values>CLMNCEP,CORE2_NYF,CORE2_IAF,CORE_IAF_JRA,ERA5,CPLHIST</valid_values>
<valid_values>CLMNCEP,CORE2_NYF,CORE2_IAF,CORE_IAF_JRA,ERA5,CPLHIST,1PT</valid_values>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just an idea but this could be SPOINT or something like that. 1PT did not make sense to me when I saw first time.

Copy link
Collaborator

@uturuncoglu uturuncoglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that this will not affect anything in HAFS side and data configurations.

@jedwards4b jedwards4b merged commit eceb024 into ESCOMP:master Apr 23, 2021
@jedwards4b jedwards4b deleted the neon_streams branch April 23, 2021 23:11
uturuncoglu added a commit to uturuncoglu/CDEPS that referenced this pull request Nov 15, 2022
Update NOAA-EMC/CDEPS to include changes from ESCOMP/CDEPS.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants