Create cplhist mode for dice #290
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adapt docn_datamode_cplhist for dice_datamode_cplhist * Fix .or. and local variables have different names in docn and dice * Add Si_imask. Decide whether to have flds_i2o_per_cat for cplhist method. * Copy sea ice stream fields to export state fields via dshr_dfield_add * Switches So_t from C to K. Decide on which/add switch * Overwrite missing value of 0 K in Si_t * Handle So_t in C and K in docn_datamode_cplhist_mod.F90 Need model SST to be in K if (minval(So_t) .LT. 100.0_r8), convert C-->K * Only fill docn_datamode_cplhist export variables if associated. Handle units of So_t based on namelist input * Default convert SST C to K (as currently). Then switch based on optional sst_constant_value * Allow null return for taux too in dice/dice_datamode_cplhist_mod.F90 * Add doc for dice cplhist mode to dice.rst
|
This shouldn't affect baselines in CESM. I am happy to start CESM testing to confirm but am learning on the fly on derecho. Can I check these steps? I don't see where baselines are stored to compare. |
jedwards4b
requested changes
Aug 2, 2024
…c.F90 errors are handled internally in that subroutine and do not return
jedwards4b
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
A new dice_datamode_cplhist_mod is adapted from docn_datamode_cplhist_mod.
Specific notes
Contributors other than yourself, if any:
CDEPS Issues Fixed (include github issue #): NOAA-EMC#61
Are there dependencies on other component PRs (if so list):
Are changes expected to change answers (bfb, different to roundoff, more substantial): bfb for existing and new for new datamode
Any User Interface Changes (namelist or namelist defaults changes): Existing sst_constant_value namelist value is used in docn_datamode_cplhist_advance to handle SST units in K and C.
Testing performed (e.g. aux_cdeps, CESM prealpha, etc): UFS regression testing (ufs-community/ufs-weather-model#2186)
Hashes used for testing: See ufs-community/ufs-weather-model#2186