Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addition of namelist based skip restart functionality to dlnd, docn, drof, dwav #180

Merged
merged 2 commits into from
Aug 25, 2022

Conversation

mvertens
Copy link
Collaborator

Description of changes

addition of namelist based skip restart functionality to dlnd, docn, drof, dwav

Specific notes

New science use cases require the ability to have skip restart functionality that is togged by namelist input for docn/prescribed sst.
As a result, I have also added this to dlnd, drof and dwav. dice cannot have this since its prognostic and needs the restart.
The same also holds for dlnd. New xml variables have been introduced in cime_config for dlnd, docn, drov and dwav so that this behavior can be togged.

Contributors other than yourself, if any: None

CDEPS Issues Fixed: None

Are there dependencies on other component PRs (if so list): No

Are changes expected to change answers: bfb

Any User Interface Changes (namelist or namelist defaults changes): Yes - for dlnd, docn, drof and dwav new namelist variables skip_restart_read

Testing performed (e.g. aux_cdeps, CESM prealpha, etc):
Verified that the following still restarted exactly when the DXXX_RESTART_READ xml variable was set to TRUE.
ERS_Ld3.f45_g37_rx1.A.cheyenne_intel
ERS_Ld3.f09_f09_mg17.1850_SATM_DLND%SCPL_SICE_SOCN_SROF_SGLC_SWAV.cheyenne_intel
ERS_Ld3.f09_f09_mg17.1850_SATM_DLND%SCPL_SICE_SOCN_SROF_SGLC_SWAV.cheyenne_intel

Hashes used for testing: cesm2_3_alpha09c with cdeps0.12.58

Copy link
Contributor

@jedwards4b jedwards4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

skip_restart_read=false is a double negative, I think that we should avoid it if possible. Also why can't this logic be added to dshr_mesh_init which is already shared code which sets the read_restart variable. Doing this would avoid a lot of code duplication.

@mvertens
Copy link
Collaborator Author

@jedwards4b - thanks for reviewing this. Agreed about the double negative - but then I have to change it back in datm.
dice and som cannot use this flag - since they must always have restart. That's why it cannot go in dshr_mesh_init.

Copy link
Collaborator

@uturuncoglu uturuncoglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mvertens i tested this and datm_cdeps_control_cfsr UFS RT is passing.

@mvertens
Copy link
Collaborator Author

@uturuncoglu - thank you for testing this!

@mvertens mvertens merged commit 7c3a567 into ESCOMP:master Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants