Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarification wrt mixing ratios #16

Merged
merged 2 commits into from
Aug 3, 2021

Conversation

ligiabernardet
Copy link
Collaborator

In these PR I clarified the use of (mass and volume) mixing ratios, as well as the representation of soil moisture. These clarifications are meant to address comments submitted during the review of #13.

@ligiabernardet
Copy link
Collaborator Author

@gold2718 @climbfuji @dudhia

Copy link
Collaborator

@climbfuji climbfuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this! Thanks!

@cacraigucar
Copy link
Collaborator

Adding @mattldawson as he pointed out the inconsistency initially.

@@ -56,6 +56,15 @@ CCPP Standard Name Rules
representing quantities at the interface between grid cells vertically,
use at_interface.

#. By default, *mixing_ratio* refers to mass mixing ratios. Volume mixing ratios should be
qualified as *volume_mixing_ratio*. Mass mixing ratios should contain information regarding
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Volume mixing ratio sentence may not be needed as examples of this would be unlikely in microphysics schemes.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Volume mixing ratio appear for chemical compositions, and are important in radiation parameterizations. We already have several standard names that start with volume_mixing_ratio (of co2, n2o, ch4, etc.). So, I think this sentence is needed.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would still like the term, "mass mixing ratio", to appear in the field's long_name property. Could this be added?

Also, as long as we are at it, should we add a rule for number concentration? The usage in #13 sometimes has the term last (e.g., prescribed_cloud_droplet_number_concentration) and sometimes it is first (e.g., mass_number_concentration_of_aerosol_from_gocart_climatology). CF seems to always have it first (although it does not have any terms called mass_number_concentration).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While these rules are for standard names, we can add a recommendation for using the word "mass" in the long name.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am okay with this change, @dudhia, please "Resolve" this conversation if you agree.

of vapor: the standard name *specific_humidity* should be used instead of
*mixing_ratio_of_vapor_wrt_moist_air*. When referring to soil quantities,
*volume_fraction* should be used to express the volumetric soil moisture.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Soil moisture should be a separate point from the microphysics paragraph above.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, we can put the soil aspect in a different bullet

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine now.

@dudhia
Copy link
Collaborator

dudhia commented Jul 30, 2021 via email

Copy link
Collaborator

@gold2718 gold2718 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a couple of questions and one suggested change.

StandardNamesRules.rst Show resolved Hide resolved
@@ -56,6 +56,15 @@ CCPP Standard Name Rules
representing quantities at the interface between grid cells vertically,
use at_interface.

#. By default, *mixing_ratio* refers to mass mixing ratios. Volume mixing ratios should be
qualified as *volume_mixing_ratio*. Mass mixing ratios should contain information regarding
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would still like the term, "mass mixing ratio", to appear in the field's long_name property. Could this be added?

Also, as long as we are at it, should we add a rule for number concentration? The usage in #13 sometimes has the term last (e.g., prescribed_cloud_droplet_number_concentration) and sometimes it is first (e.g., mass_number_concentration_of_aerosol_from_gocart_climatology). CF seems to always have it first (although it does not have any terms called mass_number_concentration).

@ligiabernardet
Copy link
Collaborator Author

Regarding @gold2718 's comment about number concentration, we can indeed clarify this in the rules. We likely want number_concentration_of_X, to match CF conventions. For number concentration, per unit of volume (m-3) is the default and if the quantity is per unit of mass (kg -1), a qualifier must be used: mass_number_concentration.

@ligiabernardet
Copy link
Collaborator Author

ligiabernardet commented Aug 2, 2021

All comments have been addressed in the last update. @dudhia @gold2718 Please take a look.

@ligiabernardet ligiabernardet requested a review from gold2718 August 2, 2021 23:03
Copy link
Collaborator

@gold2718 gold2718 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, thanks!

@climbfuji climbfuji merged commit 9e1774d into ESCOMP:main Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants