-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarification wrt mixing ratios #16
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this! Thanks!
Adding @mattldawson as he pointed out the inconsistency initially. |
StandardNamesRules.rst
Outdated
@@ -56,6 +56,15 @@ CCPP Standard Name Rules | |||
representing quantities at the interface between grid cells vertically, | |||
use at_interface. | |||
|
|||
#. By default, *mixing_ratio* refers to mass mixing ratios. Volume mixing ratios should be | |||
qualified as *volume_mixing_ratio*. Mass mixing ratios should contain information regarding |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Volume mixing ratio sentence may not be needed as examples of this would be unlikely in microphysics schemes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Volume mixing ratio appear for chemical compositions, and are important in radiation parameterizations. We already have several standard names that start with volume_mixing_ratio (of co2, n2o, ch4, etc.). So, I think this sentence is needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would still like the term, "mass mixing ratio", to appear in the field's long_name property. Could this be added?
Also, as long as we are at it, should we add a rule for number concentration? The usage in #13 sometimes has the term last (e.g., prescribed_cloud_droplet_number_concentration
) and sometimes it is first (e.g., mass_number_concentration_of_aerosol_from_gocart_climatology
). CF seems to always have it first (although it does not have any terms called mass_number_concentration
).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While these rules are for standard names, we can add a recommendation for using the word "mass" in the long name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am okay with this change, @dudhia, please "Resolve" this conversation if you agree.
of vapor: the standard name *specific_humidity* should be used instead of | ||
*mixing_ratio_of_vapor_wrt_moist_air*. When referring to soil quantities, | ||
*volume_fraction* should be used to express the volumetric soil moisture. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Soil moisture should be a separate point from the microphysics paragraph above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, we can put the soil aspect in a different bullet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine now.
Maybe some separation of microphysics, radiation, and soil paragraphs could
be done.
…On Fri, Jul 30, 2021 at 2:11 PM ligiabernardet ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In StandardNamesRules.rst
<#16 (comment)>
:
> @@ -56,6 +56,15 @@ CCPP Standard Name Rules
representing quantities at the interface between grid cells vertically,
use at_interface.
+#. By default, *mixing_ratio* refers to mass mixing ratios. Volume mixing ratios should be
+ qualified as *volume_mixing_ratio*. Mass mixing ratios should contain information regarding
Volume mixing ratio appear for chemical compositions, and are important in
radiation parameterizations. We already have several standard names that
start with *volume_mixing_ratio* (of co2, n2o, ch4, etc.). So, I think
this sentence is needed.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#16 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEIZ77HD6H4ADQSX6F3ACJLT2MBO7ANCNFSM5BI75A4Q>
.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a couple of questions and one suggested change.
StandardNamesRules.rst
Outdated
@@ -56,6 +56,15 @@ CCPP Standard Name Rules | |||
representing quantities at the interface between grid cells vertically, | |||
use at_interface. | |||
|
|||
#. By default, *mixing_ratio* refers to mass mixing ratios. Volume mixing ratios should be | |||
qualified as *volume_mixing_ratio*. Mass mixing ratios should contain information regarding |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would still like the term, "mass mixing ratio", to appear in the field's long_name property. Could this be added?
Also, as long as we are at it, should we add a rule for number concentration? The usage in #13 sometimes has the term last (e.g., prescribed_cloud_droplet_number_concentration
) and sometimes it is first (e.g., mass_number_concentration_of_aerosol_from_gocart_climatology
). CF seems to always have it first (although it does not have any terms called mass_number_concentration
).
Regarding @gold2718 's comment about number concentration, we can indeed clarify this in the rules. We likely want number_concentration_of_X, to match CF conventions. For number concentration, per unit of volume (m-3) is the default and if the quantity is per unit of mass (kg -1), a qualifier must be used: mass_number_concentration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now, thanks!
In these PR I clarified the use of (mass and volume) mixing ratios, as well as the representation of soil moisture. These clarifications are meant to address comments submitted during the review of #13.