Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cam6_4_016: Modify RRTMGP interface for MT configurations. #1100

Merged
merged 4 commits into from
Jul 25, 2024

Conversation

brian-eaton
Copy link
Collaborator

@brian-eaton brian-eaton commented Jul 24, 2024

Modify the RRTMGP interface for the special case when the minimum valid pressure for RRTMGP (1 Pa) falls in the top model layer (as it does in CAM's 93 level MT configuration). The modification is to use the "extra layer" code path, and add a very thin extra layer just below 1 Pa. The algorithm to calculate the midpoint pressure in the "extra layer" has changed from the original (which assumed a model top at 0 Pa). Hence the change affects answers for the low top model configurations (LT and cam6) as well as the MT configuration.

Note that this modification is still being tested for scientific validity in the MT configuration.

Issue #1097 - HEMCO reference in .gitmodules is a branch not a tag.

Closes #1097
Closes #1063

@brian-eaton brian-eaton added answer changing answer changing tag externals externals updating issue or PR Science science issue and/or PR labels Jul 24, 2024
@brian-eaton brian-eaton requested a review from cacraigucar July 24, 2024 15:02
@brian-eaton brian-eaton self-assigned this Jul 24, 2024
Copy link
Collaborator

@cacraigucar cacraigucar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you make any changes beyond what @brianpm provided? If so, do we need a quick review from him?

@cacraigucar cacraigucar changed the title Modify RRTMGP interface for MT configurations. cam6_4_016: Modify RRTMGP interface for MT configurations. Jul 24, 2024
@brian-eaton
Copy link
Collaborator Author

No. This PR currently has just what @brianpm provided.

@brian-eaton
Copy link
Collaborator Author

@brianpm, @PeterHjortLauritzen, @adamrher . Unfortunately these mods change answers for all RRTMGP runs. The calculation of the midpoint pressure in the extra layer is different for LT versions than it was before. The original midpoint pressure calculation in the extra layer ignored the fact that the top interface was placed at 1 Pa (effectively assumed it was 0), so the new calculation is more accurate, but different. Should we just go with this and say we expect all RRTMGP runs to have answer changes?

@brianpm
Copy link
Collaborator

brianpm commented Jul 25, 2024

Hmmmmm. I didn't think of that. I guess I'm leaning toward going ahead with the change. Interested to hear if @PeterHjortLauritzen or @adamrher have a different thought.

@PeterHjortLauritzen
Copy link
Collaborator

I concur with @brianpm

@brian-eaton
Copy link
Collaborator Author

brian-eaton commented Jul 25, 2024

Thanks! I agree that it's best to move ahead with this change. The new calculation for the midpoint pressure of the "extra layer" is more robust than the original. Also, this doesn't change answers when WACCM is run with RRTMGP. Only the MT and low top model configurations are affected.

@brian-eaton brian-eaton merged commit 3e9a281 into ESCOMP:cam_development Jul 25, 2024
gold2718 pushed a commit to gold2718/CAM that referenced this pull request Oct 16, 2024
Merge pull request ESCOMP#1100 from brian-eaton/rrtmgp-mt

cam6_4_016: Modify RRTMGP interface for MT configurations.

ESCOMP commit: 3e9a281
gold2718 pushed a commit to gold2718/CAM that referenced this pull request Oct 16, 2024
Merge pull request ESCOMP#1100 from brian-eaton/rrtmgp-mt

cam6_4_016: Modify RRTMGP interface for MT configurations.

ESCOMP commit: 3e9a281
gold2718 pushed a commit to gold2718/CAM that referenced this pull request Nov 8, 2024
Merge pull request ESCOMP#1100 from brian-eaton/rrtmgp-mt

cam6_4_016: Modify RRTMGP interface for MT configurations.

ESCOMP commit: 3e9a281
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
answer changing answer changing tag externals externals updating issue or PR Science science issue and/or PR
Projects
Status: Tag
Development

Successfully merging this pull request may close these issues.

4 participants