Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve performance of rh file write #1043

Merged

Conversation

jedwards4b
Copy link

Reorders variables in the rh files. Significantly improves file write performance on derecho.

Fixes #1042

@cacraigucar cacraigucar requested a review from peverwhee May 24, 2024 20:25
@cacraigucar cacraigucar added the misc tag issue or PR candidate for upcoming misc tag label May 24, 2024
Copy link
Collaborator

@peverwhee peverwhee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. Thanks, @jedwards4b !

brian-eaton added a commit to brian-eaton/CAM that referenced this pull request Jul 23, 2024
@brian-eaton
Copy link
Collaborator

@jedwards4b, I'm getting a regression test failure with this mod. Starting from current cam_development (cam6_4_014) merge in this PR and run the izumi/nag test:
ERC_D_Ln9.f10_f10_mg37.QPC6.izumi_nag.cam-outfrq3s_cospsathist
The run fails (I've repeated the failure 3 times) with the following error reported in cesm.log:

Abort with message NetCDF: Start+count exceeds dimension bound in file
/fs/cgd/data0/fischer/ParallelIO/src/clib/pio_darray_int.c at line 998

No traceback is reported.
The outfrq3s_cospsathist test uses several history files with various types of output.

@jedwards4b
Copy link
Author

Thanks - I'll try to reproduce.

@jedwards4b
Copy link
Author

@brian-eaton I don't think that this is a critical PR - I would suggest that you build the cam tag without it I will debug and update this PR for a future tag.

@brian-eaton
Copy link
Collaborator

Thanks Jim. Sounds like a plan.

@brian-eaton brian-eaton merged commit 1729681 into ESCOMP:cam_development Jul 23, 2024
@jedwards4b
Copy link
Author

Did you intend to merge this?

@brian-eaton
Copy link
Collaborator

This PR was originally in the miscellaneous fixes PR #1072 which I just merged. When I ran into the test failure and isolated it to this PR I pulled it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
misc tag issue or PR candidate for upcoming misc tag
Projects
Status: Tag
Development

Successfully merging this pull request may close these issues.

4 participants