Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration javax -> jakarta if anyone need it #787

Closed
wants to merge 2 commits into from

Conversation

rjunqueira
Copy link

Can help someone

@kwwall
Copy link
Contributor

kwwall commented Jun 6, 2023

If you wish to fork ESAPI and support a esapi-jakarta version, then go for it, but the ESAPI team does not have enough resources to support both javax.servlet and jakarta.servlet namespaces.

We have discussed this at length at #768, but simply abandoning all current clients using ESAPI is not something that we are ready to do.

Therefore, I am rejecting this PR for the reasons mentioned above. (Now if you can automate this so that 2 versions are supported via Maven so we don't have twice the ongoing support effort, we are certainly willing to do that.)

@kwwall kwwall closed this Jun 6, 2023
@rjunqueira
Copy link
Author

Hello,

Yes i have read your "big issue". Currently i'll maintain my fork (doing periodic refresh) until i find some time to automatize this think as you want (maybe using github scripts/features instead of maven ... avoiding nightmare)

@KatrukOV
Copy link

KatrukOV commented Jun 13, 2023

@rjunqueira Could you explain please, where you got this dependency from?

<groupId>org.apache.commons</groupId>
<artifactId>commons-fileupload2</artifactId>
<version>2.0-SNAPSHOT</version>

@rjunqueira
Copy link
Author

rjunqueira commented Jun 13, 2023

@KatrukOV

Sorry i have forget to include that :
<repository> <id>apache.snapshots</id> <name>Apache Development Snapshot Repository</name> <url>https://repository.apache.org/content/repositories/snapshots/</url> <releases> <enabled>false</enabled> </releases> <snapshots> <enabled>true</enabled> </snapshots> </repository>

So it's here : https://repository.apache.org/content/repositories/snapshots/org/apache/commons/commons-fileupload2/

@kwwall
Copy link
Contributor

kwwall commented Jun 14, 2023

@KatrukOV - Not that it matters all that much to me, after all, it's your own fork and all, but as a developer, I never want to have a dependency depend on 'snapshots' of anything. That's fine if you want to live on the bleeding edge, but not of you want to provide something that is will be used by enterprise production-ready software. If it were an emergency patch release and that were the only workaround, then perhaps that would be fine as a temporary thing, but long term, I would be cautious using any library that would even rely on a RC (release candidate) much less a SNAPSHOT version.

@rjunqueira
Copy link
Author

@KatrukOV it's ok as we have fixed a specific snapshot version for us to avoid surprises .

But the only changes of this version 2.0 is the split to supports javax and jakarta (and it will be API compatible). It's near to be released since months (and now their are continuing moving and modifying poms and md files)

cf https://github.com/apache/commons-fileupload

@kwwall
Copy link
Contributor

kwwall commented Jun 15, 2023

Sounds like the 2.0-SNAPSHOT is only a temporary thing after which you'll start using a stable release, so it's probably not a problem, although I probably would at least note that as a comment in your pom.xml.

@KatrukOV
Copy link

I think one also needs to change <project.java.target> to the new version.
In my case, I deactivated some plugins and reports, and this is enough for testing ESAPI with jakarta.
Thanks for the opportunity to try this with jakarta.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants