Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New approach for translations using a library that runs locally. #217

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

ChrisJohnNOAA
Copy link
Contributor

Description

Uses a new approach for translations that relies on a local running library.

Fixes #159

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)- replaces old message translation code
  • This change requires a documentation update

Checklist before requesting a review

  • I have performed a self-review of my code
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@ChrisJohnNOAA ChrisJohnNOAA merged commit db58e31 into ERDDAP:main Oct 16, 2024
1 check passed
@ChrisJohnNOAA ChrisJohnNOAA deleted the new_translations branch October 16, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Translation script should default to only translating messages that are new or have changed
1 participant