Fix JettyTests etopo mtime (get from test file)

[srstsavage]

Description

Fixes JettyTests#testEtopoGridFiles by getting WEB-INF/ref/etopo1_ice_g_i2.bin mtime directly from file instead of hardcoding it.

Also remove gha-test from GHA Maven build/target branches (no longer needed).

Note: trying a fresh PR because GHA test failed and I don't have permissions to rerun them.

Type of change

• Bug fix (non-breaking change which fixes an issue)

Checklist before requesting a review

• I have performed a self-review of my code
• My code follows the style guidelines of this project
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

[ChrisJohnNOAA]

It looks like the testGpcp failed, but that is due to an external server that recently stopped responding. I'm not sure if there's an easy change there or if we should disable that test.

[srstsavage]

Yeah, looks like FileVisitorDNLSTests#testGpcp was the only failure due to this page not returning expected results:

https://www.ncei.noaa.gov/data/global-precipitation-climatology-project-gpcp-daily/

Many NCEI systems are currently down due to impacts from Hurricane Helene

https://www.noaa.gov/news/some-noaa-ncei-websites-systems-down-due-to-helene-devastation-in-asheville-nc

and I don't believe there's an expected timeline for getting them back online yet. So I agree, probably makes sense to disable/skip that test for now, and make a note or issue to restore it once the service is available again.

[srstsavage]

Added that temporary test skip and a context init fix (context.setDatasetsThatFailedToLoadSB(new StringBuilder())) that you previously identified. Should be good assuming the tests pass this time.

[ChrisJohnNOAA]

Looks good, but I'll wait for the tests to finish before merging.

[ChrisJohnNOAA]

The failure on the action is likely a permission problem. The tests all passed, I merged this pull.

[srstsavage]

Build failed with a single test failure

Error:  Errors: 
Error:    JettyTests.checkForUncaughtSpecialText:4840 Runtime 
* Trouble: java.io.IOException: HTTP status code=503 for URL: http://localhost:8080/erddap/de/tabledap/glerlAvgTemp.graph
(Error {
    code=503;
    message="Service Unavailable: Es gab ein (vorübergehendes?) Problem. Warten Sie eine Minute und versuchen Sie es dann erneut. (Klicken Sie in einem Browser auf die Schaltfläche Neu laden.)";
})

which seems intermittent. I don't have permission to re-run.

[srstsavage]

Also for the automated dependency tracking/submission, here's the plugin page:

https://github.com/marketplace/actions/maven-dependency-tree-dependency-submission

If you'd prefer to wait on setting up dependency graph tracking we can remove this bit for now.

[ChrisJohnNOAA]

Also for the automated dependency tracking/submission, here's the plugin page:

https://github.com/marketplace/actions/maven-dependency-tree-dependency-submission

If you'd prefer to wait on setting up dependency graph tracking we can remove this bit for now.

I think everything is set up, but it was still failing. I removed it for now.

Relatedly while I was looking through settings as part of this, I enabled this as a separate workflow:
https://github.com/ERDDAP/erddap/actions/workflows/dependency-graph/auto-submission
which I believe includes the maven dependency submission, so maybe we're all set?

[srstsavage]

Yep, seems to be working!

https://github.com/ERDDAP/erddap/network/dependencies