Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable several error prone checks #179

Merged
merged 2 commits into from
Jul 29, 2024

Conversation

ChrisJohnNOAA
Copy link
Contributor

Description

Enables and fixes issues with a number of the ErrorProne checks. The checks I enabled were focused on threading issues, number conversions, formatting, and unused code.

Type of change

Please delete options that are not relevant.

  • [ X ] Reduce technical debt

Checklist before requesting a review

  • [ X ] I have performed a self-review of my code
  • [ X ] My code follows the style guidelines of this project
  • [ X ] I have commented my code, particularly in hard-to-understand areas
  • [ X ] I have made corresponding changes to the documentation
  • [ X ] My changes generate no new warnings
  • [ X ] I have added tests that prove my fix is effective or that my feature works
  • [ X ] New and existing unit tests pass locally with my changes

@ChrisJohnNOAA ChrisJohnNOAA merged commit 2ef97c8 into ERDDAP:main Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant