-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Markdown format #13
Open
silvester-pari
wants to merge
1
commit into
main
Choose a base branch
from
markdown-format
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Markdown format #13
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,70 @@ | ||
--- | ||
title: Demo story | ||
author: EOX | ||
format: scrollytelling | ||
navigation: true | ||
--- | ||
|
||
# Section 1 | ||
Some content here using basic markdown. | ||
|
||
# Section 2 {#identifier .class .class key=value key=value} | ||
Some code examples: | ||
```js | ||
const foo = "bar" | ||
``` | ||
|
||
```js {.dark} | ||
const bla = "blub" | ||
``` | ||
|
||
# Videos | ||
Simple video embed: | ||
{{< video https://www.youtube.com/embed/wo9vZccmqwc >}} | ||
|
||
Advanced video embed: | ||
{{< video https://www.youtube.com/embed/wo9vZccmqwc | ||
title="What is the CERN?" | ||
start="116" | ||
aspect-ratio="21x9" | ||
>}} | ||
|
||
# DIVs | ||
A simple HTML div with a class: | ||
|
||
::: {.simple-div} | ||
Some **md** div content. | ||
::: | ||
|
||
Nested DIVs: | ||
|
||
::::: {#id .parent-div} | ||
::: {.child-div} | ||
Some **md** div content. | ||
::: | ||
::::: | ||
|
||
# Page Layout | ||
See https://quarto.org/docs/authoring/article-layout.html | ||
|
||
# Embedding an eox-element | ||
<eox-map id="one"><img alt="placeholder image" src="https://placehold.co/600x400" /></eox-map> | ||
|
||
```{js} | ||
document.querySelector("eox-map#one").config = { | ||
view:{ | ||
center:[0,0], | ||
zoom:7 | ||
}, | ||
layers:[ | ||
{ | ||
type:"Tile", | ||
source:{ | ||
type:"OSM" | ||
} | ||
} | ||
] | ||
} | ||
|
||
``` | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
--- | ||
title: Hero section | ||
author: EOX | ||
format: scrollytelling | ||
--- | ||
|
||
## This title is not visible {.hero .full height=70% title="My title"} | ||
{{< video https://www.youtube.com/embed/wo9vZccmqwc >}} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
--- | ||
title: Map steps | ||
author: EOX | ||
format: scrollytelling | ||
--- | ||
|
||
<eox-map id="tour" .config=${{ | ||
view:{ | ||
center:[0,0], | ||
zoom:7 | ||
}, | ||
layers:[ | ||
{ | ||
type:"Tile", | ||
properties: { | ||
id: "foo" | ||
}, | ||
source:{ | ||
type:"OSM" | ||
} | ||
}, | ||
{ | ||
type:"Tile", | ||
properties: { | ||
id: "bar" | ||
}, | ||
source:{ | ||
type:"OSM" | ||
} | ||
} | ||
] | ||
}}></eox-map> | ||
## Climate Related Disaster {.sidecar .left map="#tour"} | ||
### Section Step 1 {.step zoom='1' lat='20.333' lon='30.232' duration='4000' layers='["foo"]'} | ||
Step 1 content | ||
|
||
### Section Step 2 {.step zoom='1' lat='20.333' lon='30.232' duration='4000' layers='["foo", "bar"]'} | ||
Step 2 content | ||
|
||
### Section Step 3 {.step zoom='1' lat='20.333' lon='30.232' duration='4000' stac='https://[...]/collection.json'} | ||
Step 3 content |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't it better to avoid injecting
html
andjs
code directly into markdown but try to make it similar to the section pattern, something like this -# eox-map { #tour center='[0,0]' zoom='7' layers='[{"type":"Tile","properties":{"id":"foo"},"source":{type:"OSM"}}]' }
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will help us to avoid unnecessary code injection into the storytelling renderer and which may cause unnecessary output.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would also think we discussed not wanting to allow code injection. This is also why we moved away from concepts such as MDX and MDJS, right?