Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide default log level of info for non-configured loggers. #110

Merged
merged 7 commits into from
Aug 22, 2019
Merged

Provide default log level of info for non-configured loggers. #110

merged 7 commits into from
Aug 22, 2019

Conversation

heifner
Copy link
Contributor

@heifner heifner commented Aug 22, 2019 •
edited
Loading

  • Modify logger_config::update_logger to setup a logger with the default logger if no logging.json is provided.
  • This will make non-default loggers have a default log level of the default logger, currently that is info.

@heifner heifner changed the title Provide default log level of warn for non-configured loggers. Provide default log level of info for non-configured loggers. Aug 22, 2019
arhag
arhag suggested changes Aug 22, 2019
View reviewed changes
include/fc/log/logger.hpp Show resolved Hide resolved
src/log/logger_config.cpp Outdated Show resolved Hide resolved
@heifner heifner merged commit c9e7389 into master Aug 22, 2019
@heifner heifner deleted the default-logger branch August 22, 2019 15:58
@heifner heifner mentioned this pull request Aug 22, 2019
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arhag arhag arhag approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@heifner @arhag