Skip to content
This repository has been archived by the owner on Aug 30, 2022. It is now read-only.

Fixed crash when serializing an invalid dictionary #233

Merged
merged 1 commit into from
Oct 23, 2019

Conversation

paulhyunkim
Copy link
Contributor

Fixes EOSIO/eosio-swift-vault#40

The crash was seen from vault but the source of the crash is in the sdk when JSONSerialization attempts to

@paulhyunkim paulhyunkim requested review from a team October 23, 2019 15:00
@paulhyunkim paulhyunkim added the bug Something isn't working label Oct 23, 2019
Copy link
Contributor

@mjohnson12 mjohnson12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@opi-smccoole opi-smccoole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@paulhyunkim paulhyunkim merged commit 26b8fe2 into develop Oct 23, 2019
@opi-smccoole
Copy link
Contributor

We probably should do a similar change anywhere else we use JSONSerialization as a future task.

@paulhyunkim
Copy link
Contributor Author

Created an issue for the future task
#234

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants