New options for api nodes - 2.0

[heifner]

Change Description

• --p2p-accept-transactions arg (=1) Allow transactions received over p2p
  network to be evaluated and relayed if valid.
• --api-accept-transactions arg (=1) Allow API transactions to be evaluated
  and relayed if valid.

• read-mode = irreversible now asserts unless:

  • p2p-accept-transactions = false
  • api-accept-transactions = false

• Resolves Introduce new read-mode to nodeos: api-read-only #8685 by user specifying:

  • read-mode = head
  • p2p-accept-transactions = false
  • api-accept-transactions = true

Consensus Changes

• Consensus Changes

API Changes

• API Changes

Documentation Additions

• Documentation Additions

Updated Descriptions:

--read-mode arg (=speculative)

• Database read mode ("speculative", "head", "read-only", "irreversible").
  In "speculative" mode: database
  contains state changes by transactions
  in the blockchain up to the head block
  as well as some transactions not yet
  included in the blockchain.

• In "head" mode: database contains state
  changes by only transactions in the
  blockchain up to the head block;
  transactions received by the node are
  relayed if valid.

• In "read-only" mode: (DEPRECATED: see
  p2p-accept-transactions &
  api-accept-transactions) database
  contains state changes by only
  transactions in the blockchain up to
  the head block; transactions received
  via the P2P network are not relayed and
  transactions cannot be pushed via the
  chain API.

• In "irreversible" mode: database
  contains state changes by only
  transactions in the blockchain up to
  the last irreversible block;
  transactions received via the P2P
  network are not relayed and
  transactions cannot be pushed via the chain API.

New Options:

--p2p-accept-transactions arg (=1) Allow transactions received over p2p
network to be evaluated and relayed if valid.
--api-accept-transactions arg (=1) Allow API transactions to be evaluated
and relayed if valid.

[swatanabe-b1]

This could use a better name. I don't see how the api's are read-only in this mode.

[heifner]

@swatanabe-b1 point well taken, we decided on api

[heifner]

We have discussed this some more and have decided that api and the existing read-only are not really database read-modes. Plan on adding p2p-accept-transactions and api-accept-transactions both defaulted to true. The existing read-only will be deprecated in favor of specifying: read-mode = head, p2p-accept-transactions = false, and api-accept-transactions = false. For the v2.0.x & v1.8.x versions of this PR read-mode = read-only will indicate a warning message of deprecation and will automatically set p2p-accept-transactions = false, api-accept-transactions = false, and read-mode = head. The develop version of this PR will remove read-only mode.

The new api mode will be provided by specifying read-mode = head, p2p-accept-transactions = false, and api-accept-transactions = true.

[arhag]

Requesting changes just to prevent accidental merging. For details see: #8702 (comment)