This repository was archived by the owner on Aug 2, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ator operation. Also abort on erased iterators and do not allow them to be resurrected by kv_set.
Store chainbase iterators instead of doing a key lookup on every iter…
Bill eosio.kvram as RAM.
Also fix a bug where decrementing an end iterator with a prefix that consists of zero or more 'FF' bytes when there exist other contract tables would always return end.
tbfleming
commented
Feb 28, 2020
arhag
suggested changes
Mar 4, 2020
3 tasks
Avoid aliasing the key and value spans within the kv_set intrinsic calls made in test contracts used for the `kv_tests/notify` unit tests.
Merge develop into kv-database
- Removed `disk_trace`, renamed `ram_trace` to `storage_usage_trace` and use it everywhere. - Removed deep mind arguments in `kv_chainbase_context` and use `apply_context` directly instead.
Also no need for alignment check in core_precondition because we only use spans of [const] char for now and EOS VM does not properly support spans of general types due to alignment problems.
Added deep mind support for KV database branch
Fixes corner cases of aliasing check that the previous implementation failed at. The kv_tests/alias unit tests now pass.
Fix aliasing issues with new host function system
arhag
approved these changes
Apr 24, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Consensus Changes
API Changes
Documentation Additions