Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

net_plugin correctly handle unknown_block_exception - develop #7948

Merged
merged 1 commit into from
Sep 18, 2019
Merged

net_plugin correctly handle unknown_block_exception - develop #7948

merged 1 commit into from
Sep 18, 2019

Conversation

heifner
Copy link
Contributor

@heifner heifner commented Sep 18, 2019

Change Description

  • net_plugin call of get_block_id_for_num was not catching unknown_block_exception causing nodeos to shutdown when block not found.

Consensus Changes

  • Consensus Changes

API Changes

  • API Changes

Documentation Additions

  • Documentation Additions

@heifner heifner changed the title net_plugin correctly handle unknown_block_exception net_plugin correctly handle unknown_block_exception - develop Sep 18, 2019
jgiszczak
jgiszczak approved these changes Sep 18, 2019
View reviewed changes
Copy link
Contributor

@jgiszczak jgiszczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're sure about catch( ... ) rather than catching unknown_block_exception specifically.

@heifner heifner merged commit e1ba4cf into develop Sep 18, 2019
@heifner heifner deleted the unknown-block-exception-dev branch September 18, 2019 21:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jgiszczak jgiszczak jgiszczak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@heifner @jgiszczak