This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
promote read-only disablement log from net_plugin to warn level #7886
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
The message that net_plugin was disabling incoming connections was only info level. This seems a serious enough message to promote to warning level so it's easier to spot because some users have been caught by it. Plus, I've made it so if incoming connection are already disabled (
p2p-listen-endpoint
is empty) then there is no warning, so it's not necessarily going to be warning spam.This does change the behavior so that instead of setting
p2p-max-nodes-per-host
to 0 the entire listening socket is disabled instead. I think that's fine as it's "more off".Consensus Changes
API Changes
Documentation Additions