Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

promote read-only disablement log from net_plugin to warn level #7886

Merged
merged 1 commit into from
Sep 11, 2019

Conversation

spoonincode
Copy link
Contributor

@spoonincode spoonincode commented Sep 11, 2019

Change Description

The message that net_plugin was disabling incoming connections was only info level. This seems a serious enough message to promote to warning level so it's easier to spot because some users have been caught by it. Plus, I've made it so if incoming connection are already disabled (p2p-listen-endpoint is empty) then there is no warning, so it's not necessarily going to be warning spam.

This does change the behavior so that instead of setting p2p-max-nodes-per-host to 0 the entire listening socket is disabled instead. I think that's fine as it's "more off".

Consensus Changes

  • Consensus Changes

API Changes

  • API Changes

Documentation Additions

  • Documentation Additions

Copy link
Contributor

@heifner heifner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a better way to do this and I agree this should be a warning. However, in the description it is not correct to say info is not reported, as info is now the default since #7792

@spoonincode
Copy link
Contributor Author

yeah not sure why I mixed that up; I even tried it and didn't think I saw it printed as info but yep it's there

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants