This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
wtmsig block production #7404
Merged
wtmsig block production #7404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ned authority structure, still fixing bugs and compile errors
…c to solve ABI versioning and contract upgrade issues. TODO: implement intrinsic changes, implement mult-sig signed blocks, fix tests etc
…tester setup to use the interim bios until features are activated
…es for wtmsig block production, augment tester to accomodate
…the activation of the protocol features. Added v2 snapshots based on a deterministic blockchain and added test to make sure that recreateing the blockchain and loading the compatible snapshot produce the same integrity hash
…ger necessary to maintain
…oducer_authority etc
b1bart
added
the
CONSENSUS
…ig-block-production
…ig-block-production
arhag
suggested changes
Jul 24, 2019
arhag
reviewed
Jul 25, 2019
arhag
suggested changes
Jul 25, 2019
There was a problem hiding this comment.
Part 2 of review: covers changes addressing comments from previous review as well as the changes made in this PR to the plugins. That includes changes to the state_history_plugin, but I would like @tbfleming to review that specific part of it as well.
Review of changes related to tests still remain for part 3 of the review.
tbfleming
reviewed
Jul 25, 2019
arhag
suggested changes
Jul 26, 2019
refactored the wtmsig tests so that they are only testing that those authorities work. added a utility to produce blocks (with a limit) until a set of BPs has been seen
arhag
approved these changes
Jul 26, 2019
heifner
approved these changes
Jul 26, 2019
This was referenced Jul 29, 2019
3 tasks
This was referenced Sep 27, 2019
This was referenced Oct 9, 2019
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
This change implements #7403
This now encompasses (and fixes conflicts from) #7421
Remaining work:
Consensus Changes
see #7403
API Changes
new deployments of the API will emit
producer_authority's for all block signing data regardless of feature activation (it will not backport to the legacy structure)specifically the
get_producersAPI will no longer guarantee the result has a fieldproducer_key. Instead it will returnproducer_authority. In instances where theproducer_authorityappears to be a canonical "upsert" of the legacy single key, this API will still emit theproducer_keyfield as expected. In those instances, theproducer_authorityfield will contain a 1-of-1 wtmsig where both the threshold and weight are exactly1Documentation Additions
need to document
set_proposed_producers_ex, see TBD PR in eosio.cdtOther notes
this PR is likely to conflict with #7012 as that will also bump the snapshot version. This PR should give way to a PR regarding that featureResolved as #7012 was merged todevelopand this PR is caught up.this PR includes #7401 as it introduces an otherwise breaking change to the in-memory format