This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
remove repeat register of history_plugin #6280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If the repeated line you mentioned is https://github.com/EOSIO/eos/blob/master/programs/nodeos/CMakeLists.txt#L55, I think it's not for loading history_plugin in runtime, but it tries link |
|
It is actually registered via: You are correct that explicit register in main is not needed. |
heifner
approved these changes
Nov 14, 2018
|
okay , misunderstand about that . but same result . hah ! very nice . |
heifner
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove repeat register of history_plugin from nodeos.