Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Build and push docker containers to automation gcr #6131

Merged
merged 1 commit into from
Oct 25, 2018

Conversation

benbenben1010
Copy link
Contributor

Change Description

When commits are merged to develop, master, or release/*, trigger a build
that builds containers for builder, eos, and eos-dev,
and push them to a private gcr project.

Consensus Changes

None

API Changes

None

Documentation Additions

None

When commits are merged to develop, trigger a build
that builds containers for builder, eos, and eos-dev,
and push them to a private gcr project.
@heifner heifner requested a review from ericiles October 24, 2018 20:27
Copy link
Contributor

@ericiles ericiles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@wanderingbort
Copy link
Contributor

@ericiles as develop will not be released until the mid-november release, do we want to back-port this change to the release/1.4.x branch so that these changes are represented in the master branch in the next patch release? Or will buildkite find it in the develop branch for now?

@wanderingbort wanderingbort merged commit 44778d3 into develop Oct 25, 2018
@wanderingbort wanderingbort deleted the push-containers-to-auto-gcr branch October 25, 2018 03:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants