This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Remove llvm@4 force link for Mac OS X builds #6100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spoonincode
reviewed
Oct 24, 2018
| if (UNIX) | ||
| if (APPLE) | ||
| if (LLVM_DIR STREQUAL "" OR NOT LLVM_DIR) | ||
| set(LLVM_DIR "/usr/local/Cellar/llvm@4/4.0.1/lib/cmake/llvm") |
There was a problem hiding this comment.
Where is LLVM_DIR used? I can't seem to find any other reference to it
There was a problem hiding this comment.
It is used in FindLLVM.cmake.
There was a problem hiding this comment.
okay yes I see, LLVM_DIR is used as an input hint to find_package(LLVM)
spoonincode
approved these changes
Oct 24, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
This removes brew --force link for the llvm@4 package, this force link had unfortunate side effects of overwriting the system clang++/clang with clang 4.0 and libc++ which was causing issues with binary builds.
Consensus Changes
API Changes
Documentation Additions
Before running the fixed
eosio_build.shit is recommended to runbrew remove llvm@4to allow the script to do a fresh install or at the very leastbrew unlink llvm@4.