This repository was archived by the owner on Aug 2, 2022. It is now read-only.
respect deterministic row conversion in integrity hash #6040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… which meant internal implementation differences were invalidating it for some types of rows
…ncs and reduce code that requires maintenance
heifner
approved these changes
Oct 17, 2018
wanderingbort
deleted the
feature/respect-deterministic-row-conversion-in-integrity-hash
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
To avoid leaking implementation details into snapshots, we create proxy types for some rows. For instance, if a row contains a foreign key or if a logical table was split to improve runtime performance. Those proxies were not being respected in the integrity hash calculation resulting in non-deterministic hashes. This did not affect the integrity or correctness of snapshots
Additionally, to prevent future issues, this is now routing the integrity hash through the snapshot code. This imposes slightly more runtime overhead but should be more maintainable in the future.
Consensus Changes
none
API Changes
none
Documentation Additions
none