This repository was archived by the owner on Aug 2, 2022. It is now read-only.
Fix Block Walker For Transactions #5800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ry cache for transaction id to initial transaction lookup. GH EOSIO#5674
…Ode.getBlockIdByTransId and using transCache to get information for BlockWalker. GH EOSIO#5674
jgiszczak
suggested changes
Sep 24, 2018
| self.node=node | ||
| self.startBlockNum=startBlockNum | ||
| self.endBlockNum=endBlockNum | ||
|
|
||
| def walkBlocks(self): | ||
| start=None | ||
| end=None | ||
| if self.trans is None and self.transId in self.transCache: | ||
| self.trans=self.transCache[self.transId] |
There was a problem hiding this comment.
This will throw a KeyError exception if self.transId is not in self.transCache. It will not return None.
There was a problem hiding this comment.
I need self.transId in self.transCache.keys(), right?
There was a problem hiding this comment.
Use self.transCache.get(self.transId). That returns None if the key is not present in the dictionary.
jgiszczak
approved these changes
Sep 24, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5674
Fixed paths where original transaction was not passed through by instead caching the original transaction and looking it up by transaction id.