This repository was archived by the owner on Aug 2, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
avoid plugin through irreversible_block signal change block before apply_block #5611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…apply_block faild. andkeep signal according to the order of accepted_transaction, applied_transaction and irreversible_block.
I'm curious what failure you are seeing. Do you have an example log? |
@heifner In sql plugin, when irrevesible_block_queue block, it will print this error and only happen in replay. I haven't used this version of sql plugin, so I can only find the previous log.
|
@firesWu What version are you running? Can you reproduce this on latest? |
@heifner I running 1.1.6 version. Now, I try to reproduce in v1.2.5. It was happen.
|
heifner
approved these changes
Sep 14, 2018
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
avoid plugin through irreversible_block signal change block before apply_block, so that apply_block faild and keep signal according to the order of accepted_transaction, applied_transaction and irreversible_block.