This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Release 1.1.4 #5098
Merged
Release 1.1.4 #5098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in #5001 the ability to bill appropriate CPU time for `soft_fail` and `hard_fail` scheduled transaction was added. However, this exposes an ambiguity in the block structure: There is no way to represent the objective failure of a scheduled transaction due to this limit. This is because the measurement is subjective and must be strictly less than or equal to this limit otherwise the _block_ is objectively bad. As a result, producers will no longer include those scheduled transactions in their blocks, giving each producer a chance to execute it in under the limited time or to another objective failure case. Previous versions of `nodeos` were producing 0 values for billed transaction time which did not resolve the ambgiuity but shifted the failure mode from the desired mode (transaction exceeded an objective maximum) to a different failure mode (transaction under the minimum billable time) allowing those blocks to validate correctly despite the mismatch. resolves #5057
Update README.md
producer plugin was treating leeway cpu exceptions as subjective which in turn implies to the rest of the producer code that the block is exhausted. However, this exception rarely clears in a fresh block (only on wall-clock wobble) so it is in-appropriate for the producer plugin to consider this "subjective"
…-fail-ambiguous-dtrx-case make scheduled transactions subjectively fail on tx_cpu_usage_exceeded
…-producer-subjective remove producer-subjectivness from leeway
Update asset.hpp
- Various regression/unit tests Co-authored-by: Kevin Heifner <[email protected]> Co-authored-by: Matt Witherspoon <[email protected]>
Backport of `fix/asset_mult_and_div` onto `release/1.1.x`
Consolidated Security Fixes for 1.1.4
bump version to 1.1.4
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.