This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Update MongoDB test and enable same. #4367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heifner
reviewed
Jun 27, 2018
| #endif() | ||
| if(BUILD_MONGO_DB_PLUGIN) | ||
| add_test(NAME nodeos_run_test-mongodb COMMAND tests/nodeos_run_test.py --mongodb -v --clean-run --dump-error-detail WORKING_DIRECTORY ${CMAKE_BINARY_DIR}) | ||
| endif() |
There was a problem hiding this comment.
I think we should make it one of the long-running tests.
There was a problem hiding this comment.
Disagree, Its not much more than the nodeos smoke test. Here are the numbers from the Darwin build:
27/38 Test #27: unit_test_wavm ....................... Passed 425.79 sec
31/38 Test #31: nodeos_run_test ...................... Passed 59.68 sec
33/38 Test #33: nodeos_run_test-mongodb .............. Passed 94.07 sec
35/38 Test #35: restart-scenarios-test-resync ........ Passed 153.00 sec
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.