Implement support for read-only contract queries in nodeos #10189

jgiszczak · 2021-03-26T02:38:29Z

Change Description

Implement support for read-only contract queries in nodeos.

Change Type

Select ONE:

Documentation

Stability bug fix

Other

Other - special case

Testing Changes

Select ANY that apply:

New Tests

Existing Tests

Test Framework

CI System

Other

Consensus Changes

Consensus Changes

API Changes

API Changes

Documentation Additions

Documentation Additions

plugins/producer_plugin/producer_plugin.cpp

Implement cleos support for new RPC API

…read_only_query_EPE-746

Update cleos support for new RPC API

Use updated structure of get_contract_query_params in cleos

plugins/chain_interface/include/eosio/chain/plugin_interface.hpp

plugins/chain_plugin/chain_plugin.cpp

plugins/chain_api_plugin/chain_api_plugin.cpp

plugins/chain_plugin/chain_plugin.cpp

plugins/producer_plugin/producer_plugin.cpp

unittests/contracts/CMakeLists.txt

unittests/contracts/read_only_query_tests.abi

…mmand push transaction

plugins/chain_plugin/include/eosio/chain_plugin/chain_plugin.hpp

Test verifies new cleos option --return-failure-trace is accepted but does not test its functionality.

Implement support for read-only contract queries in nodeos

2795e6d

heifner reviewed Mar 27, 2021

View reviewed changes

plugins/producer_plugin/producer_plugin.cpp Outdated Show resolved Hide resolved

heifner reviewed Mar 27, 2021

View reviewed changes

plugins/producer_plugin/producer_plugin.cpp Outdated Show resolved Hide resolved

nickjjzhao and others added 16 commits March 31, 2021 20:12

Add resulting URL for read-only queries into cleos

1942d92

Add a transaction in cleos for contract query

ac252a7

Print contract query output as JSON

3ea0af1

Make new cleos command contract_query as a subcommand of get

1fdde7b

Merge pull request #10221 from EOSIO/read_only_query_EPE-747

008b2a3

Implement cleos support for new RPC API

Follow through on new read_only flag in producer plugin

08f3d71

Merge branch 'read_only_query_EPE-746' of github.com:/EOSIO/eos into …

a18ec6c

…read_only_query_EPE-746

Fix a bug that fails to invoke new RPC API get_contract_query

a9b6faf

Merge pull request #10223 from EOSIO/read_only_query_EPE-747

1623b47

Update cleos support for new RPC API

Use updated structure of get_contract_query_params in cleos

1aa6b10

Merge pull request #10225 from EOSIO/read_only_query_EPE-747

7cf0077

Use updated structure of get_contract_query_params in cleos

Use read_only flag in producer plugin initialize

aafaec5

Add read-only query integration test

9bd1d7f

Merge develop

836a641

Add read-only query integration test contracts

2054d61

Merge branch 'develop' into read_only_query_EPE-746

00cb72e

jgiszczak self-assigned this May 13, 2021

jgiszczak marked this pull request as ready for review May 13, 2021 14:24

jgiszczak requested a review from brianjohnson5972 May 13, 2021 14:41

heifner suggested changes May 14, 2021

View reviewed changes

jgiszczak requested a review from dimas1185 May 17, 2021 15:11

jgiszczak added 6 commits May 18, 2021 17:10

Remove unused code.

d556965

Remove unused code.

91ff0c4

Minor optimizations.

14e2f49

Repair bad merge, restoring subjective billing and failure tracking.

630b0c7

Eliminate useless assert on rarely used method.

fb19e7e

Rename get_contract_query to push_ro_transaction.

d02a7ea

Add option to return failure traces.

cf34342

brianjohnson5972 requested a review from heifner May 20, 2021 21:21

Add read-only query integration test to test suite.

f4d1714

victorj8 reviewed May 20, 2021

View reviewed changes

unittests/contracts/read_only_query_tests.abi Show resolved Hide resolved

nickjjzhao added 3 commits May 21, 2021 18:59

Change cleos command get contract_query to push ro_transaction

8feac98

Add two flags for cleos command push ro_transaction

4994b2f

Remove cleos command push ro_transaction and add two new flags for co…

2627125

…mmand push transaction

larryk85 approved these changes May 24, 2021

View reviewed changes

heifner reviewed May 24, 2021

View reviewed changes

plugins/chain_plugin/include/eosio/chain_plugin/chain_plugin.hpp Outdated Show resolved Hide resolved

jgiszczak added 2 commits May 24, 2021 11:50

Don't return failure traces by default.

df09841

Update integration test to push transaction API.

822d90f

Test verifies new cleos option --return-failure-trace is accepted but does not test its functionality.

heifner approved these changes May 24, 2021

View reviewed changes

jgiszczak merged commit f858206 into develop May 25, 2021

jgiszczak deleted the read_only_query_EPE-746 branch May 25, 2021 06:00

softprofe mentioned this pull request Jan 7, 2022

Support read only transactions 📦 #11020

Merged

12 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement support for read-only contract queries in nodeos #10189

Implement support for read-only contract queries in nodeos #10189

jgiszczak commented Mar 26, 2021

Implement support for read-only contract queries in nodeos #10189

Implement support for read-only contract queries in nodeos #10189

Conversation

jgiszczak commented Mar 26, 2021

Change Description

Change Type

Testing Changes

Consensus Changes

API Changes

Documentation Additions