DAWN-261 ⁃ Investigate and solve reported activity that causes EOSC to crash

[blockone-syncclient]

Need to investigate (and resolve if we need to) why this program crashes EOSD?

From Dan: We should integrate his example contract into our unit tests

https://github.com/michaeljyeates/eosshop/tree/eosccrash

ATC:

• I've updated tests/eosd_run_test.sh to verify eosc does not crash in this situation.
• Step to manually reproduce:
  • Use the simpledb contract as it exhibited the same crashing as the above github shop contract.
  • Set the contract without first creating the simpledb account. This is key as it is the error message from the account not being there that was causing eosc to crash.
  • programs/eosc/eosc set contract simpledb contracts/simpledb/simpledb.wast contracts/simpledb/simpledb.abi

[blockone-syncclient]

➤ Kevin Heifner commented:

The core dump was in eosc when trying to localize an error message. The actual error it was trying to localize was that the account did not exist for the contract being pushed. Will be putting better error handling around the error handling code itself since it was the attempt to generate a better error message that was core dumping.

[blockone-syncclient]

➤ Bezwada Satyapravin commented:

Tested with 8th Dec 2017 tag release and it does not crash:

Output is as follows:

641648ms main.cpp:1166 main ] Failed with error: Assert Exception (10)
status_code == 200: Error code 500
: {"code":500,"message":"Internal Service Error","details":"unknown key"}