Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Remove dead code from fork_database #7100

Closed
hqueue opened this issue Apr 10, 2019 · 0 comments
Closed

Remove dead code from fork_database #7100

hqueue opened this issue Apr 10, 2019 · 0 comments

Comments

@hqueue
Copy link

hqueue commented Apr 10, 2019 •
edited
Loading

Following two member functions of fork_datatbase are not used anymore since PR #6149 which remove controller::push_confirmation.

  • fork_database::add( const header_confirmation& c )
  • fork_database::set_bft_irreversible( block_id_type id )

Let's cleanup above dead code if there is no chance of using them in future.
hqueue added a commit to hqueue/eos that referenced this issue Apr 10, 2019
@hqueue
Remove dead code from fork_database
17e9e03 
Remove following dead code from fork_database

- fork_database::add( const header_confirmation& c )
- fork_database::set_bft_irreversible( block_id_type id )

Closes EOSIO#7100

Signed-off-by: Hyung-Kyu Choi <[email protected]>
@hqueue hqueue mentioned this issue Apr 10, 2019
Closed
3 tasks
@heifner heifner closed this as completed Apr 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@heifner @hqueue