Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Wallet API restricted to localhost #333

Closed
toonsevrin opened this issue Sep 5, 2017 · 3 comments
Closed

Wallet API restricted to localhost #333

toonsevrin opened this issue Sep 5, 2017 · 3 comments
Assignees
Labels
Milestone

Comments

@toonsevrin
Copy link
Contributor

This is not fun for a dockerized environment, can this check be made ignorable?
https://github.com/EOSIO/eos/blob/master/plugins/wallet_api_plugin/wallet_api_plugin.cpp#L103

@heifner
Copy link
Contributor

heifner commented Sep 12, 2017

@bytemaster Do you want to remove the localhost restriction on eos-walletd?

@heifner
Copy link
Contributor

heifner commented Sep 13, 2017

@bytemaster Indicated that this restriction can be removed and replaced with a warning.

@heifner heifner self-assigned this Sep 14, 2017
@heifner
Copy link
Contributor

heifner commented Sep 14, 2017

So I'm thinking the warning should be:

              "*************************************\n"
              "*                                   *\n"
              "*  --   Wallet NOT on localhost  -- *\n"
              "*  - Password and/or Private Keys - *\n"
              "*  - are transferred unencrypted. - *\n"
              "*                                   *\n"
              "*************************************\n");

Will put this small change in as a PR tomorrow morning.

heifner added a commit that referenced this issue Sep 15, 2017
bytemaster added a commit that referenced this issue Sep 23, 2017
heifner added a commit that referenced this issue Sep 25, 2017
bytemaster added a commit that referenced this issue Sep 26, 2017
@thomasbcox thomasbcox added this to the EOS Dawn 2.0 milestone Nov 28, 2017
taokayan pushed a commit to taokayan/eos that referenced this issue May 15, 2019
Replace references of uint256_t with checksum256
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants