Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Light validation on new blocks before adding to fork_db #2204

Closed
arhag opened this issue Apr 6, 2018 · 1 comment
Closed

Light validation on new blocks before adding to fork_db #2204

arhag opened this issue Apr 6, 2018 · 1 comment

Comments

@arhag
Copy link
Contributor

arhag commented Apr 6, 2018

Right now we only check if a received block is linkable to an existing block in fork_db but do no other checks. If the network code also doesn't reject multiple blocks at the same block height from the same node, it opens itself up to an easy DOS attack.

Rather than relying only on the network code to protect against such attacks, we should do some light validation of the received blocks (particularly enough to check that it was correctly signed by an active producer from the perspective of that block) before including it into the fork_db.

@arhag arhag added the SECURITY label Apr 6, 2018
@arhag arhag added this to the RC2 milestone Apr 6, 2018
@jgiszczak jgiszczak self-assigned this Apr 18, 2018
jgiszczak added a commit that referenced this issue Apr 18, 2018
Also fix typo in assert message.
heifner added a commit that referenced this issue Apr 20, 2018
Validate expected block signee of new block #2204
@andriantolie andriantolie self-assigned this Apr 23, 2018
@andriantolie
Copy link
Contributor

ATC defined in PR #2488 pass

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants