Error on missing plugin before unknown option #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change appbase to error out when seeing an unknown plugin before erroring out on an unknown option. Otherwise it’s a little confusing that the reason the option isn’t recognized is because the plugin simply doesn’t even exist. To accomplish this, have to make two passes through config.ini. First pass just parses the plugin= statements and then makes sure those are all valid, second pass parses all options. Keep in mind this doesn’t change behavior where you can set a plugin option and not activate said plugin. For example I can still put bnet-threads in my config.ini but this will not be an error even I forgot to activate eosio::bnet_plugin
|
@spoonincode Are you still interested in getting this change in. Seems like a good idea. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change appbase to error out when seeing an unknown plugin before erroring out on an unknown option. Otherwise it’s a little confusing that the reason the option isn’t recognized is because the plugin simply doesn’t even exist.
To accomplish this, have to make two passes through config.ini. First pass just parses the plugin= statements and then makes sure those are all valid, second pass parses all options.
Keep in mind this doesn’t change behavior where you can set a plugin option and not activate said plugin. For example I can still put bnet-threads in my config.ini but this will not be an error even I forgot to activate eosio::bnet_plugin