Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add to_bin opaque overload. #92

Merged
merged 1 commit into from
Nov 30, 2020
Merged

Add to_bin opaque overload. #92

merged 1 commit into from
Nov 30, 2020

Conversation

cijujohn
Copy link
Contributor

Type opaque was missing the to_bin overload required for binary transformation. This patch fixes it.

tbfleming
tbfleming suggested changes Nov 30, 2020
View reviewed changes
Copy link
Contributor

@tbfleming tbfleming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to_bin shouldn't be a member. Ignore the from member; that slipped through the cracks.

tbfleming
tbfleming approved these changes Nov 30, 2020
View reviewed changes
Copy link
Contributor

@tbfleming tbfleming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for now. opaque needs a re-review sometime in the future.

@tbfleming tbfleming merged commit 00417b5 into EOSIO:master Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgiszczak jgiszczak jgiszczak approved these changes

@tbfleming tbfleming tbfleming approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cijujohn @tbfleming @jgiszczak