Tox

[BorjaEst]

Create tox configuration with at least the following:

• Common testenv
• Cover testenv
• Pep8 testenv

[BorjaEst]

I cherry picked the basic setup.cfg from #59, but we can merge the final version once it is finished.
For the moment this is only a start with a basic tox configuration (or the idea).

[BorjaEst]

In my computer (using conda) tox is having some troubles to install uWSGI.

    lto1: fatal error: bytecode stream in file ‘/home/borja/miniconda3/envs/flask/lib/python3.8/config-3.8-x86_64-linux-gnu/libpython3.8.a’ generated with LTO version 6.0 instead of the expected 8.1
    compilation terminated.
    lto-wrapper: fatal error: gcc returned 1 exit status
    compilation terminated.
    /home/borja/miniconda3/envs/flask/compiler_compat/ld: error: lto-wrapper failed
    collect2: error: ld returned 1 exit status
    *** error linking uWSGI ***
    ----------------------------------------

Probably, uWSGI is not needed to run nor to unit test, so, it might be possible to drag it out of the minimal installation and put them into a "requirements-prod.txt" or similar.

[BorjaEst]

At this point it seems some tests are failing:

$ tox
...
eosc_perf/tests/facade_test.py ....................................                                  [ 35%]
eosc_perf/tests/io_controller_test.py ......F...F..........F....F...............................     [ 93%]
eosc_perf/tests/json_result_validator_test.py .......                                                [100%]
...

For the moment we can leave them (investigate later).
Now I would suggest to continue on the development of tox.ini to add coverage and other features.

[BorjaEst]

Tests for pep8 added. An output file is produced "flake8.log" after running $ tox. There are some recomendations, but can be fixed in long term.

[TheChristophe]

Probably, uWSGI is not needed to run nor to unit test, so, it might be possible to drag it out of the minimal installation and put them into a "requirements-prod.txt" or similar.

But uwsgi is needed by the application to run in the docker container, which does use setup.cfg, so it should stay in there I think.

To address your specific issue, I don't know much about conda, but it seems it's using your system's compiler, which is too old. Have you tried it with installing gcc through conda, like here? ContinuumIO/anaconda-issues#6619 (comment)

[BorjaEst]

Still missing the coverage, but for the rest is working

[TheChristophe]

I have removed the PR from the project board; we have the issue on the project board and that links to the PR, and if we merge the PR the issue gets closed too so it's a little redundant to have both.

[TheChristophe]

en_US.UTF-8 typo?

[BorjaEst]

ooops, yes

[TheChristophe]

Do you intend to implement the cover part or should I have a look at it (if you tell me what you mean by it)?

[BorjaEst]

I meant cover for test coverage.
Currently I am on it, trying to call coverage from tox.

Valentin know better tox, but I am trying to undestand how it exaclty works with coverage.

[BorjaEst]

To run coverage: $ tox -e cover
From myside is ready to merge.

More tox env can be added later.

As main inconvinience, I could not run test in parallel without renaming the tests.... If it is a problem we can roll back I keep searching how to use the regex option on stestr, however, I think this rename will save issues on the future (as it took me 4h to find out where the issue was).

[TheChristophe]

I've tested it and it seems to work. It seems to be missing tox in any of the requirements files however, that may be worth adding.
I'll (re-?)rebase this onto master branch because the files changed and commit history seems a bit confused and I'm not a fan of unclear git spaghetti.

[TheChristophe]

If I did this correctly, this should be all the current commits. I've also noticed cover is not in the [tox]envlist, so it's not run by default when running tox; is that intended?

[BorjaEst]

Yes, this is in order to avoid running tests twice.
To run only coverage: $ tox -e cover

[TheChristophe]

We may still want to add tox to requirements-test.txt as it's currently not present in any of the requirements I think