Solve issue - #45 Solving issues #45 - Adding a functionality that lets the user know when they copy an icon #64
Conversation
|
@shrinishant can you check with the failing checks |
|
@vinayaksh42 sir, I think i've resolved all the conflicts. Please let me know if there is still left any |
shrinishant
force-pushed
the
shrinishant
branch
from
fb2d11b to
14d098f
Compare
src/components/HowToPanel.js
Outdated
| import { ToastContainer, toast } from 'react-toastify' | ||
| import 'react-toastify/dist/ReactToastify.css' |
There was a problem hiding this comment.
Since a component like toast can be very easily reused, it would be preferable to add it to the topmost level component, rather than doing a piecemeal approach of adding it everywhere it is required.
The better way to implement it would be to add <ToastContainer /> and the CSS import in App.js and use toast anywhere it is required.
|
Can we squash the commits? |
shrinishant
force-pushed
the
shrinishant
branch
from
2fbf246 to
39be1d1
Compare
shrinishant
force-pushed
the
shrinishant
branch
from
39be1d1 to
2b8bca6
Compare
|
@chinmaym07 there are conflicts. can you rebase once? |
|
@shrinishant I think this PR is same as #71, you should close this PR if it is no longer required. |
|
Closing this PR as it is same as - #71 |
#45
I've used react-toastify library to implement this feature. All the changes have been made only into HowToPanel.js file and package.json (to install the library)