Update existing MCV if needed

During upgrade we may have MCVs created by older version using resource
instead of kind+group+version. Update existing MCVs to to the new format
on the first time we access them.

This adds a new log showing the updated scope:

    2023-09-13T21:13:26.087Z	INFO	MCV	util/mcv_util.go:334	Updating
    ManagedClusterView dr1/busybox-drpc-busybox-sample-vrg-mcv scope {Group: Version:
    Kind: Resource:VolumeReplicationGroup Name:busybox-drpc Namespace:busybox-sample
    UpdateIntervalSeconds:0} to {Group:ramendr.openshift.io Version:v1alpha1
    Kind:VolumeReplicationGroup Resource: Name:busybox-drpc Namespace:busybox-sample
    UpdateIntervalSeconds:0} {"resourceName": "busybox-drpc"}

We expect to the see this log once after an upgrade. If the MCV is
modified manually, ramen will revert the change and log this again
(this how I generated this log).

Signed-off-by: Nir Soffer <[email protected]>

controllers/util/mcv_util.go

@@ -330,7 +330,14 @@ func (m ManagedClusterViewGetterImpl) getOrCreateManagedClusterView(
 	}
 
 	if mcv.Spec.Scope != viewscope {
-		logger.Info("WARNING: existing ManagedClusterView has different ViewScope than desired one")
+		// Expected once when uprading ramen if scope format or details have changed.
+		logger.Info(fmt.Sprintf("Updating ManagedClusterView %s scope %+v to %+v",
+			key, mcv.Spec.Scope, viewscope))
+
+		mcv.Spec.Scope = viewscope
+		if err := m.Update(context.TODO(), mcv); err != nil {
+			return nil, errorswrapper.Wrap(err, "failed to update ManagedClusterView")
+		}
 	}
 
 	return mcv, nil