Address govet linter errors when moving to golangci 1.62.0 version

Predominant errors were flagged off as:
printf: non-constant format string in call to fmt.Errorf

Signed-off-by: Shyamsundar Ranganathan <[email protected]>

internal/controller/drcluster_controller.go

@@ -475,11 +475,11 @@ func (u *drclusterInstance) initializeStatus() {
 func (u *drclusterInstance) getDRClusterDeployedStatus(drcluster *ramen.DRCluster) error {
 	mw, err := u.mwUtil.GetDrClusterManifestWork(drcluster.Name)
 	if err != nil {
-		return fmt.Errorf(fmt.Sprintf("error in fetching DRCluster ManifestWork %v", err))
+		return fmt.Errorf("error in fetching DRCluster ManifestWork %v", err)
 	}
 
 	if mw == nil {
-		return fmt.Errorf(fmt.Sprintf("missing DRCluster ManifestWork resource %v", err))
+		return fmt.Errorf("missing DRCluster ManifestWork resource %v", err)
 	}
 
 	deployed := util.IsManifestInAppliedState(mw)

internal/controller/drplacementcontrol.go

@@ -339,7 +339,8 @@ func (d *DRPCInstance) RunFailover() (bool, error) {
 	const done = true
 
 	if d.instance.Spec.FailoverCluster == "" {
-		msg := "missing value for spec.FailoverCluster"
+		const msg = "missing value for spec.FailoverCluster"
+
 		addOrUpdateCondition(&d.instance.Status.Conditions, rmn.ConditionAvailable, d.instance.Generation,
 			d.getConditionStatusForTypeAvailable(), string(d.instance.Status.Phase), msg)
 

internal/controller/volumereplicationgroup_controller.go

@@ -5,6 +5,7 @@ package controllers
 
 import (
 	"context"
+	"errors"
 	"fmt"
 	"reflect"
 	"time"
@@ -23,7 +24,7 @@ import (
 	corev1 "k8s.io/api/core/v1"
 	storagev1 "k8s.io/api/storage/v1"
 	apiextensionsv1 "k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1"
-	"k8s.io/apimachinery/pkg/api/errors"
+	k8serrors "k8s.io/apimachinery/pkg/api/errors"
 	"k8s.io/apimachinery/pkg/api/meta"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/apimachinery/pkg/labels"
@@ -414,7 +415,7 @@ func (r *VolumeReplicationGroupReconciler) Reconcile(ctx context.Context, req ct
 
 	// Fetch the VolumeReplicationGroup instance
 	if err := r.APIReader.Get(ctx, req.NamespacedName, v.instance); err != nil {
-		if errors.IsNotFound(err) {
+		if k8serrors.IsNotFound(err) {
 			log.Info("Resource not found")
 
 			return ctrl.Result{}, nil
@@ -867,7 +868,7 @@ func (v *VRGInstance) separatePVCUsingPeerClassAndSC(peerClasses []ramendrv1alph
 		msg := fmt.Sprintf("peerClass matching storageClass %s not found for async PVC", storageClass.GetName())
 		v.updatePVCDataReadyCondition(pvc.Namespace, pvc.Name, VRGConditionReasonPeerClassNotFound, msg)
 
-		return fmt.Errorf(msg)
+		return errors.New(msg)
 	}
 
 	pvcEnabledForVolSync := util.IsPVCMarkedForVolSync(v.instance.GetAnnotations())
@@ -1017,7 +1018,7 @@ func (v *VRGInstance) findPeerClassMatchingSC(
 		msg := fmt.Sprintf("peerClass matching storageClass %s not found for PVC", storageClass.GetName())
 		v.updatePVCDataReadyCondition(pvc.Namespace, pvc.Name, VRGConditionReasonPeerClassNotFound, msg)
 
-		return nil, fmt.Errorf(msg)
+		return nil, errors.New(msg)
 	}
 
 	if !slices.Contains(peerClass.StorageID, storageClass.GetLabels()[StorageIDLabel]) {

internal/controller/vrg_volrep.go

@@ -635,13 +635,13 @@ func (v *VRGInstance) uploadPVandPVCtoS3Stores(pvc *corev1.PersistentVolumeClaim
 
 	if numProfilesUploaded != numProfilesToUpload {
 		// Merely defensive as we don't expect to reach here
-		msg := fmt.Sprintf("Uploaded PV/PVC cluster data to only  %d of %d S3 profile(s): %v",
+		msg := fmt.Sprintf("uploaded PV/PVC cluster data to only  %d of %d S3 profile(s): %v",
 			numProfilesUploaded, numProfilesToUpload, s3Profiles)
 		v.log.Info(msg)
 		v.updatePVCClusterDataProtectedCondition(pvc.Namespace, pvc.Name,
 			VRGConditionReasonUploadError, msg)
 
-		return fmt.Errorf(msg)
+		return errors.New(msg)
 	}
 
 	if err := v.addArchivedAnnotationForPVC(pvc, log); err != nil {
@@ -651,7 +651,7 @@ func (v *VRGInstance) uploadPVandPVCtoS3Stores(pvc *corev1.PersistentVolumeClaim
 		v.updatePVCClusterDataProtectedCondition(pvc.Namespace, pvc.Name,
 			VRGConditionReasonClusterDataAnnotationFailed, msg)
 
-		return fmt.Errorf(msg)
+		return errors.New(msg)
 	}
 
 	msg := fmt.Sprintf("Done uploading PV/PVC cluster data to %d of %d S3 profile(s): %v",
@@ -2128,7 +2128,7 @@ func (v *VRGInstance) checkPVClusterData(pvList []corev1.PersistentVolume) error
 			claimKey, prevPV.Name, thisPV.Name)
 		v.log.Info(msg)
 
-		return fmt.Errorf(msg)
+		return errors.New(msg)
 	}
 
 	return nil