Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated for Python3 #2

Merged
merged 1 commit into from
Jan 10, 2023
Merged

Updated for Python3 #2

merged 1 commit into from
Jan 10, 2023

Conversation

lfield
Copy link
Contributor

@lfield lfield commented Sep 12, 2019

No description provided.

@gwarf gwarf self-assigned this Sep 12, 2019
@gwarf
Copy link
Member

gwarf commented Sep 12, 2019

Thanks @lfield!

So as this is removing python2 support (which certainly makes sense, we need to be sure that it will behave without problems on CentOS 7 (and even 6 unfortunately).
So there may also be a need to update the related .spec file, can you please have a look?

@lfield
Copy link
Contributor Author

lfield commented Sep 12, 2019

Well I was planning to release it first in Fedora to address this issue. Python 3 is also the default version in RHEL 8. Maybe you should create a legacy Python 2 branch before merging this.

@gwarf
Copy link
Member

gwarf commented Sep 12, 2019

So for your information we have a few other related issues in some of the BDII repositories: https://github.com/orgs/EGI-Foundation/projects/5

If possible I would prefer to avoid having different branch to maintain, CentOS 6 being here still for more than a year.
I just saw that python 3 (python34) is in EPEL for CentOS 6, so it maybe an acceptable dependency (as long as we have all the required python dependencies packaged).

@lfield
Copy link
Contributor Author

lfield commented Sep 12, 2019

Fedora (also used for EPEL) has it's own spec file. I plan to look at the BDII shortly.

@gwarf
Copy link
Member

gwarf commented Sep 20, 2019

So it seems we will most probably move to python 3 support for the BDII, using python 3 from EPEL on CentOS 6 and CentOS 7.
To merge this PR we need to have all the packaging and other stuff ready for python 3.
If you give us write access to the PR we can try to participate too: https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork

@gwarf
Copy link
Member

gwarf commented Sep 20, 2019

Please also check the feedback from python-modernize: https://github.com/mitsuhiko/python-modernize

Copy link
Member

@gwarf gwarf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!
Let's merge this long pending PR, we are now looking into releasing all the BDII components with python3 support for CentOS 7, Stream 8 and Stream 9.
We will address this in follow up PRs.

@gwarf gwarf merged commit 7e5c31e into EGI-Federation:master Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants