Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Assurance information #434

Merged
merged 5 commits into from
Apr 27, 2022
Merged

Conversation

lionick
Copy link
Contributor

@lionick lionick commented Apr 18, 2022

Summary

This PR introduces instructions for assurance information that has been added to the petition view helping the VO manager to quickly see the Assurance level of the user.


Related issue : https://jira.egi.eu/browse/IMSCHM-136

@sebastian-luna-valero
Copy link
Member

Regarding the errors, see conversation in EGI-Federation/fedcloud-catchall-operations#181 (comment)

@lionick
Copy link
Contributor Author

lionick commented Apr 19, 2022

The error seems to be out of the scope of the PR. I think owners of the repo should take some actions. @gwarf

@sebastian-luna-valero
Copy link
Member

Oh sorry, I didn't mean to assign the resolution to you :)

I just wanted to share that we are seeing similar issues on other repositories and I am happy to help.

@sebastian-luna-valero
Copy link
Member

Ok, gaurav-nelson/github-action-markdown-link-check#133 has been merge and now we get the below:

  ERROR: 3 dead links found!
  [✖] #vo-management → Status: 404
  [✖] #viewing-vo-members → Status: 404
  [✖] #managing-cou-admin-members → Status: 404

Could you please have a look?
Thanks!

@lionick
Copy link
Contributor Author

lionick commented Apr 20, 2022

Ok, gaurav-nelson/github-action-markdown-link-check#133 has been merge and now we get the below:

  ERROR: 3 dead links found!
  [✖] #vo-management → Status: 404
  [✖] #viewing-vo-members → Status: 404
  [✖] #managing-cou-admin-members → Status: 404

Could you please have a look? Thanks!

Thanks Sebastian,
Although this is a bit akward, as I didn't change anything related to these anchors, and they are already in the doc and fully functional. (e.g https://docs.egi.eu/users/aai/check-in/vos/#vo-management)

@sebastian-luna-valero
Copy link
Member

Strange!
Could @gwarf have a look, please?

@gwarf gwarf added the safe for preview Pull request vetted as safe for preview label Apr 20, 2022
@github-actions
Copy link

Documentation preview deployed!

Available at https://docs.egi.eu/documentation/434

@gwarf gwarf requested a review from vardizzo-lab April 20, 2022 07:39
@gwarf gwarf added the check-in Check-in label Apr 20, 2022
@github-actions
Copy link

Documentation preview deployed!

Available at https://docs.egi.eu/documentation/434

@gwarf
Copy link
Member

gwarf commented Apr 20, 2022

For the link check let's assume it's a temporary false positive.
Tried this that said all is good:

docker run -v ${PWD}:/tmp:ro --rm -i ghcr.io/tcort/markdown-link-check:stable /tmp/content/en/users/aai/check-in/vos/_index.md

@gwarf
Copy link
Member

gwarf commented Apr 20, 2022

@vardizzo-lab can you please review this PR and let us know when it can be merged?

Copy link

@vardizzo-lab vardizzo-lab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK.

@github-actions
Copy link

Documentation preview deployed!

Available at https://docs.egi.eu/documentation/434

Copy link
Member

@gwarf gwarf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, now link check test is also passing.

@gwarf gwarf merged commit b02c13c into EGI-Federation:main Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
check-in Check-in safe for preview Pull request vetted as safe for preview
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants