Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore Min/Max values of CustomAttributes when both are set to 0 #65

Closed
JuRichter opened this issue Jun 24, 2024 · 2 comments
Closed

Ignore Min/Max values of CustomAttributes when both are set to 0 #65

JuRichter opened this issue Jun 24, 2024 · 2 comments

Comments

@JuRichter
Copy link

Hi, I'm facing a problem when importing DBCs, hwere the minumum and Maximum values of a custom attributes are set to 0. I'm working with the Vector CANDB++ Editor. The Editor ignores the validation of min max values for custom properties, when both are set to 0, and accept all Default values.

image

When importing such DBCs the DBCParser library returns 0 in such cases. Would it be possible to also ignore min/max validation by a setting or default behavior?

Best regards and you do a fantastic job,
Julius

@JuRichter JuRichter changed the title Ignore Minumum Maximum values of CustomAttributes when both are set to 0 Ignore Minimum Maximum values of CustomAttributes when both are set to 0 Jun 24, 2024
@JuRichter JuRichter changed the title Ignore Minimum Maximum values of CustomAttributes when both are set to 0 Ignore Min/Max values of CustomAttributes when both are set to 0 Jun 24, 2024
@Whitehouse112
Copy link
Contributor

Hi @JuRichter,
you are definitely right: ignoring the validation should be the default behavior when both min and max values are set to zero. We will work on that for the next release.

Thanks
Regards

@EFeru
Copy link
Owner

EFeru commented Jul 26, 2024

Fixed #66

@EFeru EFeru closed this as completed Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants