Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix link cleaning on messenger.com #2518

Merged
merged 1 commit into from
Dec 11, 2019
Merged

Fix link cleaning on messenger.com #2518

merged 1 commit into from
Dec 11, 2019

Conversation

vari
Copy link
Contributor

@vari vari commented Dec 8, 2019

Resolves: #2513

Updated wrapped link discovery (similar to FacebookTrackingRemoval)

@vari
Copy link
Contributor Author

vari commented Dec 8, 2019

I'm not sure why the test_cookie_tracker_detection and the test_options_button tests failed/timed out, but given that this is a one line change that affects only facebook+messenger wrapped link detection, the failures are probably unrelated to this change.

@ghostwords ghostwords added the first-party relating to first-party scripts label Dec 10, 2019
ghostwords
ghostwords approved these changes Dec 11, 2019
View reviewed changes
Copy link
Member

@ghostwords ghostwords left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ghostwords ghostwords merged commit a250bf5 into EFForg:master Dec 11, 2019
ghostwords added a commit that referenced this pull request Dec 11, 2019
@ghostwords
Merge pull request #2518
fc3d7ef 
Fix link unwrapping on messenger.com
@Centaurioun Centaurioun mentioned this pull request Dec 14, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghostwords ghostwords ghostwords approved these changes

Assignees
No one assigned
Labels
first-party relating to first-party scripts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Link cleaning not working on messenger.com
2 participants
@vari @ghostwords