This repository has been archived by the owner on Nov 6, 2023. It is now read-only.
[Nature.com] Remove wildcard and update subdomains #9628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For some reason, travis times out on http://data.nature.com. It's quite strange because it worked for a6bad68 but after just changing the ruleset name in 877c629, it stopped working. |
J0WI
reviewed
May 14, 2017
| structbio.nature.com | ||
| support.nature.com | ||
| xml.nature.com | ||
| xps.nature.com |
There was a problem hiding this comment.
Given the message over http:
my.nature.com has been discontinued
Following a beta pilot, my.nature.com discontinued service on April 14th, 2014.
We apologize for any inconvenience caused.
is it really necessary to include it?
There was a problem hiding this comment.
IMHO: Since this host is still up there is no excuse to not support https.
There was a problem hiding this comment.
Looks like they noticed something was up and the subdomain is now unreachable even over http.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a though one. I may be missing some rules but it shouldn't break anything (which matters more IMO).
Please also note that real https coverage for this domain is quite new (the cert is valid from 04/13 and I don't remember seeing it in https before today) so it might still be in progress.