Skip to content
This repository has been archived by the owner on Nov 6, 2023. It is now read-only.

Update Upaiyun.com.xml #8198

Merged
merged 6 commits into from
May 8, 2017
Merged

Conversation

gloomy-ghost
Copy link
Collaborator

No description provided.

@jeremyn
Copy link
Contributor

jeremyn commented Feb 9, 2017

  • Move the www.upaiyan.com rewrite rule down to directly above the general rule and with the same indentation. Use only one line for each rule. Keep the target where it is.
  • Use Secure connection failed instead of PROTOCOL_ERROR

Also, it looks like the returned pages from www.upaiyun.com and www.upyun.com have the same content, but you might add a comment saying how these domains are related: are they the same company, etc. For example it might not be clear to a non-English speaker why getdropbox.com redirects to dropbox.com even though the domains have similar letters.


Updated list (#8198 (comment)):

Upaiyun.com.xml:

Upyun.com.xml:

Remove target, note as Different HTTP/HTTPS content:

@jeremyn jeremyn self-assigned this Feb 9, 2017
@jeremyn
Copy link
Contributor

jeremyn commented Feb 13, 2017

Why did you add the target for upyun.com? Shouldn't that be a different ruleset?

Also the comment <!-- Same as www.upaiyun.com but has a valid certificate --> is a little vague. Are these the same company?

@gloomy-ghost
Copy link
Collaborator Author

It's splitted now. Two domains are operated by the same company, and have the same DNS record, share the same ICP license number.

@jeremyn
Copy link
Contributor

jeremyn commented Apr 22, 2017

I've reviewed the rulesets and updated checklist #8198 (comment).

@jeremyn
Copy link
Contributor

jeremyn commented May 8, 2017

I've pushed changes to complete the checklist in #8198 (comment). I also noted ^upaiyun.com as Invalid certificate in Upaiyun.com.xml.

@J0WI Can you review this please?

@jeremyn jeremyn removed their assignment May 8, 2017
@J0WI J0WI merged commit f84058c into EFForg:master May 8, 2017
@gloomy-ghost gloomy-ghost deleted the gloomy-ghost-upaiyun_com branch May 9, 2017 10:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants